Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipRemotes option broken due to reference to projectGraph #17473

Closed
1 of 4 tasks
Michael-Ziluck opened this issue Jun 7, 2023 · 2 comments · Fixed by #17497
Closed
1 of 4 tasks

skipRemotes option broken due to reference to projectGraph #17473

Michael-Ziluck opened this issue Jun 7, 2023 · 2 comments · Fixed by #17497
Assignees
Labels
outdated scope: angular Issues related to Angular support in Nx scope: react Issues related to React support for Nx type: bug

Comments

@Michael-Ziluck
Copy link
Contributor

Michael-Ziluck commented Jun 7, 2023

Current Behavior

When you run projects using the module-federation-dev-server, skipRemotes now only can detect projects that are returned from readCachedProjectGraph, effectively making it unusable.

If the projects are in a different repository and are not running (which is my use-case and is also other's use-case as well I'm sure), it won't be able to find them.

Expected Behavior

Specifying projects in skipRemotes that are not in the same repository should work perfectly fine.

GitHub Repo

No response

Steps to Reproduce

  1. Generate a module federation host application in a new NX repo.
  2. Generate a module federation remote application in a separate NX repo.
  3. Add a reference to the remote application in the host application.
  4. Start the host without starting the remote, using the skipRemotes input with the remote's project name.

Nx Report

>  NX   Report complete - copy this into the issue template

   Node : 18.16.0
   OS   : win32 x64
   npm  : 9.5.1

   nx                      : 16.3.2
   @nrwl/js                : 16.3.2
   @nrwl/jest              : 16.3.2
   @nrwl/linter            : 16.3.2
   @nrwl/workspace         : 16.3.2
   @nrwl/angular           : 16.3.2
   @nrwl/cli               : 16.3.2
   @nrwl/cypress           : 16.3.2
   @nrwl/devkit            : 16.3.2
   @nrwl/eslint-plugin-nx  : 16.3.2
   @nrwl/tao               : 16.3.2
   @nrwl/webpack           : 16.3.2
   typescript              : 5.0.4
   ---------------------------------------
   Community plugins:
   @auth0/auth0-angular : 2.1.0

Failure Logs

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

Caused by #17185

@Michael-Ziluck
Copy link
Contributor Author

@jaysoo @Coly010, AgentEnder told me to ping you guys in #17145 as he's on vacation.

@Coly010 Coly010 self-assigned this Jun 8, 2023
@Coly010 Coly010 added scope: react Issues related to React support for Nx scope: angular Issues related to Angular support in Nx labels Jun 8, 2023
Coly010 added a commit to Coly010/nx that referenced this issue Jun 8, 2023
Coly010 added a commit to Coly010/nx that referenced this issue Jun 9, 2023
Coly010 added a commit to Coly010/nx that referenced this issue Jun 30, 2023
Coly010 added a commit to Coly010/nx that referenced this issue Jun 30, 2023
Coly010 added a commit to Coly010/nx that referenced this issue Jun 30, 2023
Coly010 added a commit to Coly010/nx that referenced this issue Jun 30, 2023
Coly010 added a commit to Coly010/nx that referenced this issue Jun 30, 2023
Coly010 added a commit to Coly010/nx that referenced this issue Jun 30, 2023
Coly010 added a commit to Coly010/nx that referenced this issue Jun 30, 2023
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: angular Issues related to Angular support in Nx scope: react Issues related to React support for Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants