-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(misc): allow patterns matching for dev remotes and skip remotes #17185
Merged
AgentEnder
merged 1 commit into
nrwl:master
from
AgentEnder:feat/mf/use-matching-projects-functionality
May 24, 2023
Merged
feat(misc): allow patterns matching for dev remotes and skip remotes #17185
AgentEnder
merged 1 commit into
nrwl:master
from
AgentEnder:feat/mf/use-matching-projects-functionality
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
requested review from
jaysoo,
ndcunningham,
mandarini,
xiongemi,
Coly010 and
leosvelperez
as code owners
May 24, 2023 15:28
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
feat/mf/use-matching-projects-functionality
branch
from
May 24, 2023 15:30
c931469
to
5bab116
Compare
mandarini
approved these changes
May 24, 2023
leosvelperez
approved these changes
May 24, 2023
AgentEnder
force-pushed
the
feat/mf/use-matching-projects-functionality
branch
from
May 24, 2023 17:20
5bab116
to
bc9e3ae
Compare
AgentEnder
force-pushed
the
feat/mf/use-matching-projects-functionality
branch
from
May 24, 2023 18:59
bc9e3ae
to
4cd285e
Compare
jaysoo
approved these changes
May 24, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
--dev-remotes
and--skip-remotes
require explicit project namesExpected Behavior
--dev-remotes
and--skip-remotes
allow using patterns that work for--projects
,--exclude
and other similar functionality.This allows things like:
nx serve host --skip-remotes='*'
to skip all remotesRelated Issue(s)
Fixes #17145