Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): allow patterns matching for dev remotes and skip remotes #17185

Merged

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented May 24, 2023

Current Behavior

--dev-remotes and --skip-remotes require explicit project names

Expected Behavior

--dev-remotes and --skip-remotes allow using patterns that work for --projects, --exclude and other similar functionality.

This allows things like:
nx serve host --skip-remotes='*' to skip all remotes

Related Issue(s)

Fixes #17145

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 7:11pm

@nx-cloud
Copy link

nx-cloud bot commented May 24, 2023

@AgentEnder AgentEnder force-pushed the feat/mf/use-matching-projects-functionality branch from c931469 to 5bab116 Compare May 24, 2023 15:30
@AgentEnder AgentEnder force-pushed the feat/mf/use-matching-projects-functionality branch from 5bab116 to bc9e3ae Compare May 24, 2023 17:20
@AgentEnder AgentEnder force-pushed the feat/mf/use-matching-projects-functionality branch from bc9e3ae to 4cd285e Compare May 24, 2023 18:59
@AgentEnder AgentEnder enabled auto-merge (squash) May 24, 2023 19:33
@AgentEnder AgentEnder merged commit d030a21 into nrwl:master May 24, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow skipAllRemotes option to @nrwl/angular:module-federation-dev-server
4 participants