[APM] Update query input when url changes (elastic#43773) (elastic#43854

) Closes elastic#42135.
nreese · Aug 24, 2019 · 1fd8a77 · 1fd8a77
1 parent ec357c5
commit 1fd8a77
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/x-pack/legacy/plugins/apm/public/components/shared/KueryBar/Typeahead/index.js b/x-pack/legacy/plugins/apm/public/components/shared/KueryBar/Typeahead/index.js
@@ -26,13 +26,15 @@ export class Typeahead extends Component {
     isSuggestionsVisible: false,
     index: null,
     value: '',
-    inputIsPristine: true
+    initialValue: ''
   };
 
   static getDerivedStateFromProps(props, state) {
-    if (state.inputIsPristine && props.initialValue) {
+    const { initialValue } = props;
+    if (initialValue && initialValue !== state.initialValue) {
       return {
-        value: props.initialValue
+        value: initialValue,
+        initialValue
       };
     }
 
@@ -125,7 +127,6 @@ export class Typeahead extends Component {
     const hasValue = Boolean(value.trim());
     this.setState({
       value,
-      inputIsPristine: false,
       isSuggestionsVisible: hasValue,
       index: null
     });

diff --git a/x-pack/legacy/plugins/apm/public/components/shared/KueryBar/index.tsx b/x-pack/legacy/plugins/apm/public/components/shared/KueryBar/index.tsx
@@ -188,7 +188,7 @@ export function KueryBar() {
         return;
       }
 
-      history.replace({
+      history.push({
         ...location,
         search: fromQuery({
           ...toQuery(location.search),