-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Kuery bar should listen to url changes #42135
Comments
sorenlouv
added
[zube]: Inbox
bug
Fixes for quality problems that affect the customer experience
discuss
Team:APM
All issues that need APM UI Team support
labels
Jul 29, 2019
Pinging @elastic/apm-ui |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this issue
Aug 22, 2019
dgieselaar
added a commit
that referenced
this issue
Aug 23, 2019
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this issue
Aug 23, 2019
dgieselaar
added a commit
that referenced
this issue
Aug 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the kuery value in the input field has been changed, it no longer applies changes from the url.
urlParams.kuery
is passed in asinitialValue
only. So any subsequent changes are ignored:kibana/x-pack/legacy/plugins/apm/public/components/shared/KueryBar/index.tsx
Line 205 in 5aea728
The state is kept in the
TypeAhead
component:kibana/x-pack/legacy/plugins/apm/public/components/shared/KueryBar/Typeahead/index.js
Line 28 in 2dfe167
The better solution is to always derive the state from the url. So whenever the url changes, so does the value in the input. However, they should not be 1:1 since the url shouldn't update when the input value changes: only when it is submitted!
As part of this issue it would be good to change
history.replace
tohistory.push
so that new queries are added to the browser history.The text was updated successfully, but these errors were encountered: