Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Kuery bar should listen to url changes #42135

Closed
sorenlouv opened this issue Jul 29, 2019 · 1 comment · Fixed by #43773
Closed

[APM] Kuery bar should listen to url changes #42135

sorenlouv opened this issue Jul 29, 2019 · 1 comment · Fixed by #43773
Assignees
Labels
bug Fixes for quality problems that affect the customer experience discuss Team:APM All issues that need APM UI Team support

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Jul 29, 2019

When the kuery value in the input field has been changed, it no longer applies changes from the url.

urlParams.kuery is passed in as initialValue only. So any subsequent changes are ignored:

The state is kept in the TypeAhead component:

The better solution is to always derive the state from the url. So whenever the url changes, so does the value in the input. However, they should not be 1:1 since the url shouldn't update when the input value changes: only when it is submitted!

As part of this issue it would be good to change history.replace to history.push so that new queries are added to the browser history.

@sorenlouv sorenlouv added [zube]: Inbox bug Fixes for quality problems that affect the customer experience discuss Team:APM All issues that need APM UI Team support labels Jul 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience discuss Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants