Add gitHead in subdirectories too #80
Conversation
|
CI failure is because latest npm is installed on Node 4 |
|
Friendly ping? This would really help a bunch of tools in the npm ecosystem |
| return cb(null, data) | ||
| } | ||
| return githead(dir, data, cb) | ||
| } |
There was a problem hiding this comment.
I don't think so - githead() reads the .git/HEAD file (if found) and passes the content to githead_(). So to traverse up the tree and find the .git/HEAD file, we need to call githead() recursively.
githead_() is what then handles the contents of the .git/HEAD file by reading the ref it points to etc.
It's easy to get confused though with the naming of the functions and no comments...
There was a problem hiding this comment.
This looks good to me (but note: I'm not a committer here now) and per the RFC meeting either it will get merged or something that does the same thing will be. Personally I'd like to see this get merged as is to get the feature out there and in the ecosystem as early as possible.
|
Thanks for your patience here. I'm getting this repo's CI up to date and then we can rebase, relint, retest, and ship it. Note that |
Fixes #66