Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitHead missing in registry manifests for scoped packages #393

Closed
darcyclarke opened this issue Nov 8, 2019 · 4 comments
Closed

gitHead missing in registry manifests for scoped packages #393

darcyclarke opened this issue Nov 8, 2019 · 4 comments
Labels
Bug thing that needs fixing

Comments

@darcyclarke
Copy link
Contributor

  Original bug ticket: [https://npm.community/t/9739](https://npm.community/t/9739)
  Originally filed: 2019-08-28T10:58:14.876Z
@darcyclarke darcyclarke added Bug thing that needs fixing Community labels Nov 8, 2019
@felixfbecker
Copy link

Quoting @isaacs from the forum thread:

This isn’t based on whether the package is scoped, but rather whether it’s published from the root of a git repo or not.

@material-ui/core is published from a subfolder in a git repo 3 so it doesn’t get picked up.

It’d be nice if read-package-json walked up the tree to find the .git folder, but as of today, it does not, which is why this field sometimes doesn’t show up.

This was filed in npm/read-package-json#66. I created a PR for this a long time ago to fix this in npm/read-package-json#80. It would be amazing if it could be merged 🙏🏻

@felixfbecker
Copy link

@darcyclarke why close this?

@darcyclarke
Copy link
Contributor Author

Hey @felixfbecker! Sorry for any confusion here. That said, we are only expecting to make security updates to v6 as per our Support Policy now that v7 is GA

@darcyclarke
Copy link
Contributor Author

If you'd like to make a net-new issue against the project using our new issue template, it may help actually get visibility to the problem if you're still experiencing this in v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing
Projects
None yet
Development

No branches or pull requests

2 participants