Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow checkPlatform to override execution libc #71

Merged
merged 1 commit into from
Oct 6, 2023
Merged

feat: allow checkPlatform to override execution libc #71

merged 1 commit into from
Oct 6, 2023

Conversation

Brooooooklyn
Copy link
Contributor

@Brooooooklyn Brooooooklyn requested a review from a team as a code owner September 18, 2023 21:02
@Brooooooklyn Brooooooklyn mentioned this pull request Sep 18, 2023
Closed
@wraithgar
Copy link
Member

Readme will need to be updated.

Also, shouldn't this also still work in tandem with the platform check? If folks override just libc but not platform is that giving unexpected results?

@Brooooooklyn
Copy link
Contributor Author

If folks override just libc but not platform is that giving unexpected results?

I think this is a typical scenario. For example, here you need to install the dependencies on the Linux glibc platform and mount the node_modules to the Linux musl container for testing https://github.com/napi-rs/node-rs/blob/main/.github/workflows/ci.yaml#L386-L389

@wraithgar wraithgar merged commit 0419751 into npm:main Oct 6, 2023
26 checks passed
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Brooooooklyn @wraithgar