Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --libc option to override platform specific install #6817

Closed
wants to merge 1 commit into from
Closed

feat: add --libc option to override platform specific install #6817

wants to merge 1 commit into from

Conversation

Brooooooklyn
Copy link
Contributor

@Brooooooklyn Brooooooklyn commented Sep 17, 2023

@Brooooooklyn Brooooooklyn requested a review from a team as a code owner September 17, 2023 06:49
@wraithgar
Copy link
Member

Would this actually do anything? npm-install-checks doesn't allow overriding of this param currently

@Brooooooklyn
Copy link
Contributor Author

@wraithgar npm-install-checks updated

@wraithgar
Copy link
Member

wraithgar commented Oct 9, 2023

We don't typically allow external PRs to update dependencies. #6882 will update the dep then this PR will be able to land.

@Brooooooklyn
Copy link
Contributor Author

@wraithgar ready again

@wraithgar
Copy link
Member

Looks like snapshot tests in npm itself need updating.

@wraithgar
Copy link
Member

@Brooooooklyn if you don't mind, since this still needs the snapshot update I will pull these changes into a new PR next week so that they can land. I will still give you credit in the commit message.

@Brooooooklyn
Copy link
Contributor Author

@wraithgar sure! I don’t mind it. Let’s land it asap

@wraithgar
Copy link
Member

#6914

@wraithgar wraithgar closed this Oct 18, 2023
@Brooooooklyn Brooooooklyn deleted the add-libc branch March 5, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants