Check save-prefix satisfies requested install version range #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gosplit
force-pushed
the
save-prefix-according-range-requested
branch
from
729c369
to
442a88b
Compare
gosplit
force-pushed
the
save-prefix-according-range-requested
branch
from
442a88b
to
3042e1a
Compare
isaacs
added
semver:major
|
I think there's probably a better way to do this, but I get that this is a problem. If the user provides a complex range, and |
|
I agree with @isaacs. It's better if we can just save the user-provided range in the package.json file. |
darcyclarke
added
Needs Discussion
isaacs
added a commit
to npm/arborist
that referenced
this pull request
Sep 28, 2020
If a user installs `[email protected] <1.2.3`, and we resolve to `1.2.2`, then we should not save it as `^1.2.2`, since that would allow versions outside of the requested range. Explicit versions and tags are still saved using the savePrefix, since those are not ranges, and users can set `--save-exact` if they wish it to be saved exactly. Fix: #127 Fix: npm/cli#193 Fix: https://npm.community/t/7005
isaacs
added a commit
to npm/arborist
that referenced
this pull request
Sep 28, 2020
If a user installs `[email protected] <1.2.3`, and we resolve to `1.2.2`, then we should not save it as `^1.2.2`, since that would allow versions outside of the requested range. Explicit versions and tags are still saved using the savePrefix, since those are not ranges, and users can set `--save-exact` if they wish it to be saved exactly. Fix: #127 Fix: npm/cli#193 Fix: https://npm.community/t/7005
isaacs
added a commit
to npm/arborist
that referenced
this pull request
Sep 29, 2020
If a user installs `[email protected] <1.2.3`, and we resolve to `1.2.2`, then we should not save it as `^1.2.2`, since that would allow versions outside of the requested range. Explicit versions and tags are still saved using the savePrefix, since those are not ranges, and users can set `--save-exact` if they wish it to be saved exactly. Fix: #127 Fix: npm/cli#193 Fix: https://npm.community/t/7005 PR-URL: #145 Credit: @isaacs Close: #145 Reviewed-by: @isaacs
This was referenced Feb 11, 2024
This was referenced Feb 12, 2024
This was referenced Feb 12, 2024
This was referenced Feb 12, 2024
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug report is also opened in npm community.
In short, the recent Angular Compiler requires older typescript packages and asks users to run
npm install typescript@">=3.1.1 <3.3"However, after running the install command, package.json will be update to
typescript@^3.2.4, which will still pull incompatible version, eg.'[email protected]' in other build machine. So I add some checks in computeVersionSpec to ensure adding the save-prefix^or~only when it satisfies requested version range.