This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Save provided range if not a subset of savePrefix #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user installs `[email protected] <1.2.3`, and we resolve to `1.2.2`, then we should not save it as `^1.2.2`, since that would allow versions outside of the requested range. Explicit versions and tags are still saved using the savePrefix, since those are not ranges, and users can set `--save-exact` if they wish it to be saved exactly. Fix: #127 Fix: npm/cli#193 Fix: https://npm.community/t/7005
isaacs
force-pushed
the
isaacs/save-prefix-subset-check
branch
from
2e03d95
to
6aa0c2c
Compare
ruyadorno
approved these changes
Sep 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #144, land that first.
Save provided range if not a subset of savePrefix
If a user installs
[email protected] <1.2.3, and we resolve to1.2.2, then weshould not save it as
^1.2.2, since that would allow versions outsideof the requested range.
Explicit versions and tags are still saved using the savePrefix, since
those are not ranges, and users can set
--save-exactif they wish itto be saved exactly.
Fix: #127
Fix: npm/cli#193
Fix: https://npm.community/t/7005