Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to representing network and full-text NOT via ExpressionType.Not #1118

Closed
roji opened this issue Nov 7, 2019 · 0 comments · Fixed by #1248
Closed

Switch back to representing network and full-text NOT via ExpressionType.Not #1118

roji opened this issue Nov 7, 2019 · 0 comments · Fixed by #1248
Assignees
@roji
Labels
cleanup
Milestone
5.0.0

Comments

@roji
Copy link
Member

roji commented Nov 7, 2019

EF Core 3.1 broke usages of Expression.Not for non-boolean cases, mistakenly identifying them as boolean/logical - this is fixed by dotnet/efcore#18788. As a workaround we use ExpressionType.Negate internally, but after that PR is merged and we sync we should switch back to ExpressionType.Not.
@roji roji self-assigned this Nov 7, 2019
@roji roji added the refactor label Nov 7, 2019
@roji roji added this to the 5.0.0 milestone Nov 7, 2019
roji added a commit to roji/efcore.pg that referenced this issue Feb 2, 2020
@roji
Use Not instead of Negate for network/fulltext
96377fc 
Fixes npgsql#1118
@roji roji mentioned this issue Feb 2, 2020
Merged
@roji roji added cleanup and removed refactor labels Feb 2, 2020
@roji roji closed this as completed in #1248 Feb 3, 2020
roji added a commit that referenced this issue Feb 3, 2020
@roji
Use Not instead of Negate for network/fulltext
4b39e33 
Fixes #1118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Use Not instead of Negate for network/fulltext roji/efcore.pg
1 participant
@roji