Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bitwise complement (non-boolean Expression.Not) #18788

Closed
roji opened this issue Nov 6, 2019 · 0 comments · Fixed by #18789
Closed

Support bitwise complement (non-boolean Expression.Not) #18788

roji opened this issue Nov 6, 2019 · 0 comments · Fixed by #18789
Assignees
@roji
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
5.0.0

Comments

@roji
Copy link
Member

roji commented Nov 6, 2019 •
edited
Loading

DISCLAIMER: I got sucked into this just as I was about to go home, so technically this is a project done on my free personal time!

Our codebase mistakenly assumes in various places that ExpressionType.Not is boolean. Make sure bitwise complement (non-boolean ExpressionType.Not) is properly translated.

Supported by SqlServer, Sqlite, PostgreSQL, even Cosmos...
@roji roji self-assigned this Nov 6, 2019
roji added a commit that referenced this issue Nov 6, 2019
@roji
Implement non-boolean bitwise complement
a78bed1 
Fixes #18788
@roji roji mentioned this issue Nov 6, 2019
Merged
roji added a commit that referenced this issue Nov 7, 2019
@roji
Implement non-boolean bitwise complement
4f3a5c6 
Fixes #18788
roji added a commit that referenced this issue Nov 7, 2019
@roji
Implement non-boolean bitwise complement
78c7b33 
Fixes #18788
@roji roji added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 7, 2019
This was referenced Nov 7, 2019
Open
Closed
Merged
roji added a commit that referenced this issue Nov 7, 2019
@roji
Implement non-boolean bitwise complement
a41d6a8 
Fixes #18788
@ajcvickers ajcvickers added this to the 5.0.0 milestone Nov 17, 2019
@ajcvickers ajcvickers mentioned this issue Jan 31, 2020
Closed
13 tasks
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Implement non-boolean bitwise complement dotnet/efcore
2 participants
@ajcvickers @roji