Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Support 'override' param #159

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Support 'override' param #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a70caa
define 'override' param
Dec 16, 2017
8bcca31
Merge branch 'master' into feature/override
tasomaniac Jan 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/main/groovy/com/novoda/gradle/release/BintrayConfiguration.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class BintrayConfiguration {
key = propertyFinder.getBintrayKey()
publish = extension.autoPublish
dryRun = propertyFinder.getDryRun()
override = propertyFinder.getOverride()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR but why don't we have just propertyFinder.override instead of the getter. It would look little bit nicer.


publications = extension.publications ?: project.plugins.hasPlugin('com.android.library') ? ['release'] : [ 'maven' ]

Expand Down
4 changes: 4 additions & 0 deletions core/src/main/groovy/com/novoda/gradle/release/PropertyFinder.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ class PropertyFinder {
getBoolean(project, 'dryRun', extension.dryRun)
}

def getOverride() {
getBoolean(project, 'override', extension.override)
}

def getPublishVersion() {
getString(project, 'publishVersion', extension.publishVersion ?: extension.version)
}
Expand Down
1 change: 1 addition & 0 deletions core/src/main/groovy/com/novoda/gradle/release/PublishExtension.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ class PublishExtension {
String bintrayUser = ''
String bintrayKey = ''
boolean dryRun = true
boolean override = false

String[] publications

Expand Down