Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Support 'override' param #159

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Support 'override' param #159

merged 2 commits into from
Jan 17, 2018

Conversation

YusukeIwaki
Copy link
Contributor

closes #104

I created a fork of bintray-release just for using -Poverride=true in my private project, and found it works well as expected.

Could you add this feature if you like?

@hal9002
Copy link

hal9002 commented Jan 5, 2018

Can one of the admins review this PR?

StefMa
StefMa reviewed Jan 8, 2018
View reviewed changes
Copy link
Contributor

@StefMa StefMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good so far.
Can't currently test it because bintray have some API issues.. Will test it soon 👍

@StefMa
Copy link
Contributor

StefMa commented Jan 9, 2018

ok to test

@StefMa
Copy link
Contributor

StefMa commented Jan 9, 2018

Seems to be working 👍
Nice job, thank you 👍

bildschirmfoto 2018-01-09 um 08 43 25

@carterhudson
Copy link

ETA on merging this? I need this functionality.

tasomaniac
tasomaniac reviewed Jan 10, 2018
View reviewed changes
Copy link
Contributor

@tasomaniac tasomaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document this addition in documentation or a sample?

core/src/main/groovy/com/novoda/gradle/release/BintrayConfiguration.groovy
@@ -21,6 +21,7 @@ class BintrayConfiguration {
key = propertyFinder.getBintrayKey()
publish = extension.autoPublish
dryRun = propertyFinder.getDryRun()
override = propertyFinder.getOverride()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR but why don't we have just propertyFinder.override instead of the getter. It would look little bit nicer.

@StefMa
Copy link
Contributor

StefMa commented Jan 11, 2018

We haven't a real documentatiom yet. The only thing what exist is the wiki. But there you can't find anything about our properties.
I would recommend to create a issue to create a /docs/properties.md which explains all the properties. Alternative we can put it into the Readme.
But since it is "hard" to contribute to a github wiki I would not use it anymore.

@StefMa
Copy link
Contributor

StefMa commented Jan 17, 2018

@tasomaniac can we please merge that, it looks good so far.
I'll create follow up tickets 👍

@StefMa StefMa mentioned this pull request Jan 17, 2018
Closed
@tasomaniac
Copy link
Contributor

ok to test

@tasomaniac tasomaniac merged commit 644bab9 into novoda:master Jan 17, 2018
@YusukeIwaki YusukeIwaki deleted the feature/override branch January 23, 2018 14:20
@mr-archano mr-archano mentioned this pull request Mar 26, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StefMa StefMa StefMa approved these changes

@tasomaniac tasomaniac tasomaniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support override
5 participants
@YusukeIwaki @hal9002 @StefMa @carterhudson @tasomaniac