Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adlam fonts - the "joined" version doesn't show characters joining #5

Closed
sven-oly opened this issue Jan 26, 2017 · 8 comments
Closed

Comments

@sven-oly
Copy link

The new Adam fonts include an "unjoined" version NotoSansAdlam-Regular.ttf
and
NotoSansAdlamUnjoined-Regular.ttf, which is supposed to join the characters at the baseline.

However, this test does not show any joining even when the Noto Sans Adlan font is selected.
http://adlamtesting.appspot.com/

To test, paste the following text and use the font selector at the bottom.
𞤢𞤣𞤤𞤥𞤦𞤧𞤨𞤩𞤪𞤫𞤬𞤭𞤮𞤯𞤰𞤱𞤲𞤳𞤴𞤵𞤶𞤷𞤸𞤹𞤺𞤻𞤼𞤽𞤾𞤿𞥀𞥁𞥂𞥃

@punchcutter
Copy link

The font does join, but not on that testing page. Since joining is optional in Adlam you need to turn on the joining features fina, medi and init, but even that doesn't seem to work correctly in browsers. If I put any variation of
font-feature-settings:"fina", "medi", "init";
in the CSS it still only shows a mix of init and medi or something, but it doesn't apply all three correctly. Also with the latest harfbuzz I don't see correct joining behavior. I tried variations of

hb-view NotoSansAdlam-Regular.ttf --features=init,medi,fina

and I see the same half shaped text. Maybe @behdad knows what's going on there.

@punchcutter
Copy link

Here's what I get in hb-view with fina,medi,init specified and another screenshot of how it should be rendered when fina, medi and init are used.
hb-view_adlam_joined
adlam_joined

@dougfelt
Copy link

dougfelt commented Jan 26, 2017 via email

@behdad
Copy link

behdad commented Jan 26, 2017

Humm. HarfBuzz was NOT passing Adlam through Arabic shaper. Fixing now.

@punchcutter
Copy link

Looks good in hb-view now
adlam_joined_hbfixed

@sven-oly
Copy link
Author

sven-oly commented Jan 26, 2017 via email

@punchcutter
Copy link

@sven-oly This is finally working in Firefox Nightly so eventually it will get into the main release and also Chrome. I asked about Windows and Uniscribe will also be updated at some point to fix this.

@KrasnayaPloshchad
Copy link

I asked about Windows and Uniscribe will also be updated at some point to fix this.

You’d also asked about LibreOffice, since it also uses HarfBuzz everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants