-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adlam fonts - the "joined" version doesn't show characters joining #5
Comments
The font does join, but not on that testing page. Since joining is optional in Adlam you need to turn on the joining features fina, medi and init, but even that doesn't seem to work correctly in browsers. If I put any variation of
and I see the same half shaped text. Maybe @behdad knows what's going on there. |
Behdad will have to say how this gets processed by default. fina/medi/init
would typically be applied by the layout engine for Arabic when the script
was detected, and not require any external input, so if that's the
expectation for Adlam then all OT layout engines would have to do it.
Perhaps this is in a later version of Harfbuzz than the browser was using?
…On Thu, Jan 26, 2017 at 12:02 PM, Zachary Quinn Scheuren < ***@***.***> wrote:
Here's what I get in hb-view with fina,medi,init specified and another
screenshot of how it should be rendered when fina, medi and init are used.
[image: hb-view_adlam_joined]
<https://cloud.githubusercontent.com/assets/11257204/22348013/ef094870-e3be-11e6-9a86-95a9df7a2bd2.png>
[image: adlam_joined]
<https://cloud.githubusercontent.com/assets/11257204/22348012/ef069184-e3be-11e6-8373-162df0f0fd25.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/googlei18n/noto-fonts/issues/828#issuecomment-275497136>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJepDE4cMtdX2O9MteyO2hRdrECSvLogks5rWPvGgaJpZM4LuKDm>
.
|
Humm. HarfBuzz was NOT passing Adlam through Arabic shaper. Fixing now. |
Great. Thanks for finding and fixing this.
Craig Cornelius
…On Jan 26, 2017 15:11, "Zachary Quinn Scheuren" ***@***.***> wrote:
Looks good in hb-view now
[image: adlam_joined_hbfixed]
<https://cloud.githubusercontent.com/assets/11257204/22353994/0a29a1a4-e3d8-11e6-87f9-53d350ccc184.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/googlei18n/noto-fonts/issues/828#issuecomment-275543489>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKQNEs4iJhMYKGsSP_bJNP4Y2sqslcm9ks5rWSgpgaJpZM4LuKDm>
.
|
@sven-oly This is finally working in Firefox Nightly so eventually it will get into the main release and also Chrome. I asked about Windows and Uniscribe will also be updated at some point to fix this. |
You’d also asked about LibreOffice, since it also uses HarfBuzz everywhere. |
The new Adam fonts include an "unjoined" version NotoSansAdlam-Regular.ttf
and
NotoSansAdlamUnjoined-Regular.ttf, which is supposed to join the characters at the baseline.
However, this test does not show any joining even when the Noto Sans Adlan font is selected.
http://adlamtesting.appspot.com/
To test, paste the following text and use the font selector at the bottom.
𞤢𞤣𞤤𞤥𞤦𞤧𞤨𞤩𞤪𞤫𞤬𞤭𞤮𞤯𞤰𞤱𞤲𞤳𞤴𞤵𞤶𞤷𞤸𞤹𞤺𞤻𞤼𞤽𞤾𞤿𞥀𞥁𞥂𞥃
The text was updated successfully, but these errors were encountered: