Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adlam font duplicate #4653

Closed
sommerluk opened this issue Aug 18, 2022 · 0 comments · Fixed by #4658
Closed

Adlam font duplicate #4653

sommerluk opened this issue Aug 18, 2022 · 0 comments · Fixed by #4658

Comments

@sommerluk
Copy link
Collaborator

Currently, our font list has Noto Sans Adlam (with letters that are joining up like Arabic) and then Noto Sans Adlam Unjoined (as the name says, with letters that do not join up).

As far as I understand, both fonts cover the same range of Unicode code points. Therefore, as we are vendoring fonts now and all fonts in our list will actually be available, the second one (Noto Sans Adlam Unjoined) will never be used, so obviously such duplicates should be removed.

Here is how these two fonts should render (screenshot of a PDF created with Scribus):
grafik
Above the joined version, below the unjoined version.

Wikipedia says:

The letters are found either joined akin to Arabic or separate - the joined form is commonly used in a cursive manner; however, separate or block forms are also used as primarily for educational content.

The link specified as source by Wikipedia however does not say that.

The Noto documentation says:

The unjoined variant is suitable for headlines and for educational content. The cursive variant, in which letters join the same way as in Arabic and N’Ko, is suitable for most texts. Needs software support for complex text layout (shaping).

Apparently, support in the shaping engine HarfBuzz was added in 2017.

Obviously, this is working today in up-to-date HarfBuzz versions, as my Scribus example shows. It also works in KDE’s text editor and in LibreOffice. However, it does not work in Mapnik:

Noto Sans Adlam is supposed to join, but does not join in Mapnik:
joined

As comparision, here is Noto Sans Adlam Unjoined (which is similar, but not identical):
unjoined

I don’t know why it doesn’t work in Mapnik.

In any case, it doesn’t make sense to keep both fonts. What should we do?

  • Keep the joined font, knowing it will not actually join in current Mapnik, but maybe will join in later Mapnik versions.
  • Keep the unjoined font, making sure that the rendering will not change, even if later Mapnik versions will support joining.

Note that the text in the example is 𞤪𞤢𞤤𞤵𞤆 𞤥𞤢𞤤𞤣𞤀 (diplays probably in wrong order Github): I did not find a real-world example in OSM, and therefore used this artificial example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant