Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: updated notation verify command based on spec #418

Merged
merged 20 commits into from
Oct 31, 2022

Conversation

patrickzheng200
Copy link
Contributor

@patrickzheng200 patrickzheng200 commented Oct 26, 2022

This PR updates notation verify command based on the verify_spec.

Tested with notation verify on ACR.

Signed-off-by: Patrick Zheng [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #418 (89858ee) into main (4d8da74) will decrease coverage by 0.17%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   34.60%   34.43%   -0.18%     
==========================================
  Files          23       20       -3     
  Lines        1254     1121     -133     
==========================================
- Hits          434      386      -48     
+ Misses        809      727      -82     
+ Partials       11        8       -3     
Impacted Files Coverage Δ
cmd/notation/common.go 100.00% <ø> (ø)
cmd/notation/key.go 23.52% <ø> (ø)
cmd/notation/main.go 0.00% <0.00%> (ø)
cmd/notation/sign.go 36.93% <ø> (ø)
cmd/notation/verify.go 29.16% <100.00%> (ø)
internal/cmd/flags.go
internal/cmd/signer.go
internal/cmd/options.go

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yizha1 yizha1 linked an issue Oct 26, 2022 that may be closed by this pull request
@yizha1 yizha1 added this to the beta-1 milestone Oct 26, 2022
@yizha1 yizha1 requested review from yizha1, priteshbandi, rgnote, shizhMSFT and a team October 26, 2022 06:13
@JeyJeyGao
Copy link
Contributor

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 requested a review from a team October 27, 2022 05:32
@yizha1 yizha1 removed this from the beta-1 milestone Oct 27, 2022
internal/cmd/flags.go Outdated Show resolved Hide resolved
cmd/notation/verify.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Copy link

@jondonas jondonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

cmd/notation/verify.go Outdated Show resolved Hide resolved
internal/cmd/flags.go Outdated Show resolved Hide resolved
internal/cmd/flags.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 469069e into notaryproject:main Oct 31, 2022
@patrickzheng200 patrickzheng200 deleted the verify branch October 31, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implementing verify command
7 participants