Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: updated notation key command based on spec #416

Merged
merged 25 commits into from
Oct 31, 2022
Merged

update: updated notation key command based on spec #416

merged 25 commits into from
Oct 31, 2022

Conversation

patrickzheng200
Copy link
Contributor

@patrickzheng200 patrickzheng200 commented Oct 26, 2022 •
edited
Loading

This PR updates notation key command based on the key_spec.

Signed-off-by: Patrick Zheng [email protected]

@Two-Hearts
updated dependency
b910a8a 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
resolved conflicts
28b0438 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
Merge branch 'notaryproject:main' into main
4f4e2a4
@Two-Hearts
Merge branch 'notaryproject:main' into main
eea8003
@Two-Hearts
Merge branch 'notaryproject:main' into main
216cea2
@Two-Hearts
Merge branch 'notaryproject:main' into main
1267c02
@Two-Hearts
Merge branch 'notaryproject:main' into main
1c3dfbb
@Two-Hearts
Merge branch 'notaryproject:main' into main
98e5946
@Two-Hearts
Merge branch 'notaryproject:main' into main
55563d3
@Two-Hearts
Merge branch 'notaryproject:main' into main
c68d602
@Two-Hearts
Merge branch 'notaryproject:main' into main
d165a7b
@Two-Hearts
Merge branch 'notaryproject:main' into main
7166877
@Two-Hearts
updated notation key command based on spec
d67c37d 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated notation key command based on spec
6ad6fb1 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
quick fix
c8c406b 
Signed-off-by: Patrick Zheng <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022 •
edited
Loading

Codecov Report

Merging #416 (0766666) into main (a41b377) will increase coverage by 0.24%.
The diff coverage is 34.61%.

❗ Current head 0766666 differs from pull request most recent head 6f3420b. Consider uploading reports for the commit 6f3420b to get more accurate results

@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   33.91%   34.16%   +0.24%     
==========================================
  Files          21       21              
  Lines        1138     1118      -20     
==========================================
- Hits          386      382       -4     
+ Misses        744      727      -17     
- Partials        8        9       +1
Impacted Files Coverage Δ
cmd/notation/key.go 23.88% <34.61%> (+0.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yizha1 yizha1 added this to the beta-1 milestone Oct 26, 2022
@yizha1 yizha1 linked an issue Oct 26, 2022 that may be closed by this pull request
Implementing key command #389
Closed
@yizha1 yizha1 requested review from priteshbandi, rgnote, shizhMSFT and a team October 26, 2022 06:13
@Two-Hearts
fixed flags
6a858e0 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
quick update
7eada1a 
Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
JeyJeyGao approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 requested a review from a team October 27, 2022 05:31
@yizha1 yizha1 removed this from the beta-1 milestone Oct 27, 2022
shizhMSFT
shizhMSFT requested changes Oct 27, 2022
View reviewed changes
internal/cmd/flags.go Outdated Show resolved Hide resolved
cmd/notation/key.go Outdated Show resolved Hide resolved
cmd/notation/key.go Outdated Show resolved Hide resolved
@Two-Hearts
update per code review
6dbf62a 
Signed-off-by: Patrick Zheng <[email protected]>
priteshbandi
priteshbandi reviewed Oct 28, 2022
View reviewed changes
cmd/notation/key.go Outdated Show resolved Hide resolved
specs/commandline/key.md Outdated Show resolved Hide resolved
internal/cmd/flags.go Outdated Show resolved Hide resolved
priteshbandi
priteshbandi approved these changes Oct 30, 2022
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
resolve conflicts
fa0eb26 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
resolve conflicts
d8c1f7b 
Signed-off-by: Patrick Zheng <[email protected]>
@shizhMSFT shizhMSFT closed this Oct 31, 2022
@shizhMSFT shizhMSFT reopened this Oct 31, 2022
shizhMSFT
shizhMSFT approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 2992190 into notaryproject:main Oct 31, 2022
@patrickzheng200 patrickzheng200 deleted the key branch October 31, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

Assignees

@patrickzheng200 patrickzheng200

Labels
None yet
Projects
Notary Project Planning Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementing key command
7 participants
@patrickzheng200 @codecov-commenter @priteshbandi @shizhMSFT @JeyJeyGao @yizha1 @Two-Hearts