Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version to 1.7.0 #936

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Update go version to 1.7.0 #936

merged 1 commit into from
Sep 2, 2016

Conversation

riyazdf
Copy link
Contributor

@riyazdf riyazdf commented Aug 31, 2016

Bumps to go 1.7.0.

We can replace golang.org/x/net/context with context in a follow-up PR because we'll have to also bump grpc to a version that also uses context

Closes #928

Signed-off-by: Riyaz Faizullabhoy [email protected]

Signed-off-by: Riyaz Faizullabhoy <[email protected]>
@riyazdf
Copy link
Contributor Author

riyazdf commented Aug 31, 2016

yubikey hardware tests are failing because our jenkins infrastructure has go1.6, will bump the go version there and re-run :)

@riyazdf
Copy link
Contributor Author

riyazdf commented Aug 31, 2016

Installed Go 1.7 on our yubikey jenkins infrastructure and we're green!

@cyli
Copy link
Contributor

cyli commented Aug 31, 2016

That is awesome! LGTM! Thanks for keeping us up to date!

(I am strangely locally seeing some vet errors on go1.7:

server/handlers/default_test.go:419: literal copies lock value from *metaStore: github.com/docker/notary/server/storage.MemStorage contains sync.Mutex
server/handlers/default_test.go:461: literal copies lock value from *metaStore: github.com/docker/notary/server/storage.MemStorage contains sync.Mutex

But if the CI passes on 1.7 my local state must be broken.)

@riyazdf
Copy link
Contributor Author

riyazdf commented Sep 1, 2016

@cyli hm yeah that's weird. I just tried running govet against this PR on our yubikey test infrastructure and didn't run into any errors. Not sure if other folks are seeing this or what's going on 😕

@endophage
Copy link
Contributor

LGTM!

@HuKeping
Copy link
Contributor

HuKeping commented Sep 2, 2016

@cyli I tried this PR manually but didn't get those go vet warnings.

@cyli
Copy link
Contributor

cyli commented Sep 2, 2016

Thanks! It must be some kind of weird local setting or inconsistency I
have.

On Friday, September 2, 2016, HuKeping [email protected] wrote:

@cyli https://github.com/cyli I tried this PR manually but didn't get
those go vet warnings.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#936 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AANn4P6SKDCaNrmh3ArJRlmY-9rLPTdoks5qmAQtgaJpZM4JyAUg
.

@riyazdf riyazdf merged commit b69a069 into master Sep 2, 2016
@riyazdf riyazdf deleted the go1.7 branch September 2, 2016 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants