Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.7 #928

Closed
endophage opened this issue Aug 19, 2016 · 5 comments
Closed

Upgrade to Go 1.7 #928

endophage opened this issue Aug 19, 2016 · 5 comments

Comments

@endophage
Copy link
Contributor

Upgrade circle CI to use Go 1.7, fix any breakage that causes (none expected based on release notes).

This should give us faster, smaller binaries. Among other specifically interesting improvements, sha256 has been sped up by 10% or more, and we do a lot of sha256 hashing.

@cyli
Copy link
Contributor

cyli commented Aug 19, 2016

We may have some lint fixes I think for go 1.7. On RC5 I see:

server/handlers/default_test.go:419: literal copies lock value from *metaStore: github.com/docker/notary/server/storage.MemStorage contains sync.Mutex
server/handlers/default_test.go:461: literal copies lock value from *metaStore: github.com/docker/notary/server/storage.MemStorage contains sync.Mutex

@riyazdf
Copy link
Contributor

riyazdf commented Aug 19, 2016

@cyli: If I remember correctly, I think that vet issue was handled by #793?

@cyli
Copy link
Contributor

cyli commented Aug 19, 2016

I still seem to be seeing it :| It's a mutex in a different file I think

@riyazdf
Copy link
Contributor

riyazdf commented Aug 19, 2016

ah, yes, you're right. We can make a similar change 👍

@HuKeping
Copy link
Contributor

Hola Go 1.7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants