Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change function signature of to_bytes #683

Merged
merged 3 commits into from
Jan 23, 2023
Merged

change function signature of to_bytes #683

merged 3 commits into from
Jan 23, 2023

Conversation

Ethan-000
Copy link
Contributor

@Ethan-000 Ethan-000 commented Jan 21, 2023 •
edited
Loading

Related issue(s)

NOT FULLY Resolves #651

This does not fully solve the issue. Its just a change in the function name to make the endianess of to_bytes explicit

Description

Summary of changes

change function name of to_bytes to to_le_bytes

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

jfecher
jfecher approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the change!

@jfecher jfecher merged commit e13437b into noir-lang:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

std::to_bytes should specify the endian
2 participants
@Ethan-000 @jfecher