std::to_bytes should specify the endian

[kevaundray]

Problem

It's not clear what the endian is of std::to_bytes

Solution

Change it to std::to_le_bytes and or optionally add std:to_be_bytes

Alternatives considered

Its possible to just add a comment, but then it becomes cumbersome if we ever add a big_endian flavour, because you will have to_bytes and to_be_bytes

Additional context

[kevaundray]

@Ethan-000 For this, I think just changing the stdlib function would be a first step and low hanging fruit because then we stop new projects from needing to refactor their code.

Noting that there is an endian already in place -- its just that to_bytes is not explicitly specifying it

[Ethan-000]

@jfecher wait sir the pr does not fully resolves this issue, we still need a change of acvm to add to_be_bytes I think

[jfecher]

Indeed, the issue was automatically closed when the PR was merged. I'll re-open it.
Adding to_be_bytes was optional so we could leave it closed but I'll re-open it for discussion on if we want to implement that and keep this open, create another issue for big endian and close this one, or some other option.

[Ethan-000]

oh I probably shouldn't mark it as Resolves then, got it

[jfecher]

After thinking it over some, I'm going to re-resolve this issue as the central issue of specifying endian-ness has been solved. Creating a separate to_be_bytes was optional and we can revisit it at a later time if we determine it is needed.