Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] feat: Sync from aztec-packages #4304

Closed
wants to merge 112 commits into from
Closed

[TEST] feat: Sync from aztec-packages #4304

wants to merge 112 commits into from

Commits on Nov 28, 2023

  1. feat: Aztec CI files in Noir (#3430)

    This is a dual-list commit in both Noir and aztec repo. In this PR,
    Aztec gets the code to make a mirror, and the mirror action pushes to
    our `aztec` branch in Noir. The `aztec` branch features this as the
    first commit, to then be pushed one by one from master as Noir changes
    come in.
    
    ---------
    
    Co-authored-by: ludamad <[email protected]>
    2 people authored and AztecBot committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6743afc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b5046b View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Configuration menu
    Copy the full SHA
    7f1b857 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    454b140 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. Configuration menu
    Copy the full SHA
    fc00722 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Configuration menu
    Copy the full SHA
    0ad7ba5 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Configuration menu
    Copy the full SHA
    2d265b4 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Configuration menu
    Copy the full SHA
    d788414 View commit details
    Browse the repository at this point in the history
  2. feat: update to latest noir and update noir compiler (#3696)

    This PR updates aztec-packages to use latest noir.
    
    - Regarding noir_wasm, providing the solved sources directly to
    `node_wasm` eliminates the need for `source-resolver`, which has been
    completely removed from the repository.
     - Added required pub in return values
     - Updated return_type
     - Pulled latest noir
    Thunkar authored and AztecBot committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    f06ab9c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    29ff6ce View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. chore: Cleanup recursion interface (#3744)

    This is a recreation of this PR
    (AztecProtocol/aztec-packages#3528) to handle PR
    AztecProtocol/aztec-packages#3729
    
    # Checklist:
    Remove the checklist to signal you've completed it. Enable auto-merge if
    the PR is ready to merge.
    - [ ] If the pull request requires a cryptography review (e.g.
    cryptographic algorithm implementations) I have added the 'crypto' tag.
    - [ ] I have reviewed my diff in github, line by line and removed
    unexpected formatting changes, testing logs, or commented-out code.
    - [ ] Every change is related to the PR description.
    - [ ] I have
    [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
    this pull request to relevant issues (if any exist).
    
    ---------
    
    Co-authored-by: kevaundray <[email protected]>
    2 people authored and sirasistant committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    d144743 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    20f1652 View commit details
    Browse the repository at this point in the history
  3. fix: event macro (#3784)

    Fixes #3655
    benesjan authored and sirasistant committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ce02b01 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    50925ea View commit details
    Browse the repository at this point in the history
  5. chore: Just nargo compile. (#3775)

    Ok. Don't be scared. 262 files sounds horrific but it's mostly path
    updates and that kind of nonsense. The `noir-contracts` and
    `noir-compiler` changes are probably what to focus on.
    
    * We update boxes to use our build of nargo, and the modified
    code-generator.
    * We update paths in docs, as noir-contracts/src/contracts moved to
    noir-contracts/contracts, as src is now pure codegen output.
    * Contracts are now imported e.g. `import { ChildContractArtifact } from
    '@aztec/noir-contracts/Child';`. You can still just import from top
    level index, but it's pretty cruel to ask the runtime to parse all the
    artifacts just to get one, they are huge.
    * Contract files are now just named as per the name of the contract
    (i.e. not snake case). Less moving parts is better here. Given it's
    codegen output it's acceptable to allow the output names to be
    inconsistent.
    * aztec.js is now responsible for copying the account contracts into
    itself, as opposed to have some other random module push code into it.
    But we just need to get rid of this baked account stuff at some point
    anyway.
    * Got rid of lodash.zip in one place, and then restrained myself to not
    go further. But think we should remove the "trivial" lodash cases at
    some point.
    * Tidied up yp/bootstrap a bit, it's basically in line with the
    dockerfile at this point. Will prob make dockerfile just call bootstrap
    as part of some other docker cleanup I'll do later.
    * `source-map-support` in cli.
    * Remove compile command from cli. We are just going to promote use of
    aztec-nargo.
    * The ts and noir generators now expect nargo output as input, rather
    than our transformed abi. The ts generator outputs the transformed abi
    as part of it's generation.
    * Delete all the script stuff from `noir-contracts`. src folder is now
    just the codegen output, and the codegen is done with a trivial script
    to call compile and the ts generator in noir-compiler.
    * Added an unused script called `transform_json_abi.sh` that uses a tiny
    bit of jq to perform the transform. Probably to be deleted, especially
    if we just stop transforming the noir output and use it directly, but it
    served me as a useful tool at one point.
    charlielye authored and sirasistant committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    338cb57 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    717f1fa View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1005f32 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    50cb28c View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. chore: noir sync (#3884)

    Needed a bit of a graft here:
    - Looked at current commit on noir/.gitrepo, it pointed to 'just nargo
    compile' commit, fixed that to actual commit in aztec-packages branch of
    noir
    - Fixed parent commit
    - did git subrepo noir pull and fixed merge conflicts per instructions
    - this PR resulted
    ludamad committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a6289a5 View commit details
    Browse the repository at this point in the history
  2. chore!: Remove aggregation objects from RecursionConstraint (#3885)

    This removes the aggregation objects which are currently unused in the
    RecursionConstraint implementation. Next we will update the ACVM opcode
    to no longer use the aggregation object fields and update the
    serialization.
    
    # Checklist:
    Remove the checklist to signal you've completed it. Enable auto-merge if
    the PR is ready to merge.
    - [ ] If the pull request requires a cryptography review (e.g.
    cryptographic algorithm implementations) I have added the 'crypto' tag.
    - [ ] I have reviewed my diff in github, line by line and removed
    unexpected formatting changes, testing logs, or commented-out code.
    - [ ] Every change is related to the PR description.
    - [ ] I have
    [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
    this pull request to relevant issues (if any exist).
    
    ---------
    
    Co-authored-by: kevaundray <[email protected]>
    2 people authored and AztecBot committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    c0826b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. feat: update BB version

    sirasistant committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    3521d28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3366d6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    16a4f50 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c6bc062 View commit details
    Browse the repository at this point in the history
  5. style: fmt

    sirasistant committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    e9405f0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4178e74 View commit details
    Browse the repository at this point in the history
  7. chore: update bbjs

    sirasistant committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    ad7e3b1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    404ffbf View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0886b1b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    812576b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3c8f83e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    89bf498 View commit details
    Browse the repository at this point in the history
  13. Revert "chore: remove now unused bb abstraction leaks"

    This reverts commit 3c8f83e.
    TomAFrench committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    9affee6 View commit details
    Browse the repository at this point in the history
  14. chore: clippy fix

    TomAFrench committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    1725e70 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    394154e View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    39d4bfa View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    04f2bf4 View commit details
    Browse the repository at this point in the history
  18. Revert "fix: avoid decoding public inputs"

    This reverts commit 39d4bfa.
    sirasistant committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    5b64df3 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    9ec2e07 View commit details
    Browse the repository at this point in the history
  20. test: fix test

    sirasistant committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    ee2e6c0 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    742e940 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    61c2b9b View commit details
    Browse the repository at this point in the history
  23. chore: fix formatting

    sirasistant committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    114aa6f View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    ee802c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    3f6a24d View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into aztec-packages

    * master:
      chore(docs): devcontainer docs (#4007)
      chore(ci): disable commit comments on docs publishing (#3998)
      feat: simplify chains of casts to be all in terms of the original `ValueId` (#3984)
      chore: quiet down aztec-bot! (#4006)
      chore: force public functions for trait implementation (#3986)
    TomAFrench committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    f4bbe21 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into aztec-packages

    * master:
      feat: Add dependency resolver for `noir_wasm` and implement `FileManager` for consistency with native interface (#3891)
    TomAFrench committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    75c8334 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3416229 View commit details
    Browse the repository at this point in the history
  5. chore: git subrepo commit (merge) noir (#3955)

    subrepo:
      subdir:   "noir"
      merged:   "6bdab5c1e4"
    upstream:
      origin:   "https://github.com/noir-lang/noir"
      branch:   "aztec-packages"
      commit:   "75c83348e6"
    git-subrepo:
      version:  "0.4.6"
      origin:   "https://github.com/ingydotnet/git-subrepo"
      commit:   "110b9eb"
    
    ---------
    
    Co-authored-by: ludamad <[email protected]>
    Co-authored-by: Tom French <[email protected]>
    3 people authored and AztecBot committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5646354 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7c357e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. chore!: define key type in maps (#3841)

    Closes AztecProtocol/aztec-packages#2787
    
    Unfortunately key type with a `ToField` trait binding is only defined in
    the `.at` method, due to this blocker:
    
    #3954
    Thunkar authored and AztecBot committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    b5a1eb5 View commit details
    Browse the repository at this point in the history
  2. chore: fix rust tests (#3963)

    A bunch of the tests in rust are broken as the trait implementations for
    the EC operations were removed
    TomAFrench authored and AztecBot committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    5162b33 View commit details
    Browse the repository at this point in the history
  3. chore: fix formatter tests

    TomAFrench committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    55aa96f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d7c4c66 View commit details
    Browse the repository at this point in the history
  5. feat: Update noir (#3979)

    subrepo:
      subdir:   "noir"
      merged:   "945587396"
    upstream:
      origin:   "https://github.com/noir-lang/noir"
      branch:   "aztec-packages"
      commit:   "d7c4c669c"
    git-subrepo:
      version:  "0.4.6"
      origin:   "???"
      commit:   "???"
    sirasistant authored and AztecBot committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    563c704 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2024

  1. Merge branch 'master' into aztec-packages

    * master:
      feat: add `noir-compiler` checks to `aztec_macros` (#4031)
      chore: remove unnecessary visibility modifiers from u128 trait impls (#4023)
      chore(ci): install fixed version of `wasm-pack` in CI (#4034)
      chore: remove `release-tests` package (#4032)
      chore(docs): bumping playground version (#4030)
      fix: allow ast when macro errors (#4005)
      chore: provide a canonical "failing" `BlackBoxFunctionSolver` (#4028)
      feat: assert maximum bit size when creating a U128 from an integer (#4024)
    TomAFrench committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    787ccdc View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Configuration menu
    Copy the full SHA
    e7da1ab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f22446 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0f38b22 View commit details
    Browse the repository at this point in the history
  4. chore: sync noir (#4025)

    subrepo:
      subdir:   "noir"
      merged:   "0f38b229f"
    upstream:
      origin:   "https://github.com/noir-lang/noir"
      branch:   "aztec-packages"
      commit:   "0f38b229f"
    git-subrepo:
      version:  "0.4.6"
      origin:   "https://github.com/ingydotnet/git-subrepo"
      commit:   "110b9eb"
    
    Co-authored-by: kevaundray <[email protected]>
    2 people authored and AztecBot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    2d92108 View commit details
    Browse the repository at this point in the history
  5. chore: replace AztecU128 with U128 (#3951)

    TomAFrench authored and AztecBot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    001b8e0 View commit details
    Browse the repository at this point in the history
  6. fix: dont spam logs with yarn install (#4027)

    This output was getting cut off in the noir-packages ci job. This
    standardizes what was already in yarn-project
    ludamad authored and AztecBot committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    5e51255 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. fix: Start witness of ACIR generated by Noir start at zero not one (#…

    …3961)
    
    Resolves #130
    Only partially resovles
    AztecProtocol/barretenberg#816. There is some
    places like in `serialize_arithmetic_gate` where we assume that the
    `zero_idx == 0`.
    
    ---------
    
    Co-authored-by: ledwards2225 <[email protected]>
    Co-authored-by: ledwards2225 <[email protected]>
    Co-authored-by: Tom French <[email protected]>
    Co-authored-by: kevaundray <[email protected]>
    5 people authored and AztecBot committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    45165d1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4980553 View commit details
    Browse the repository at this point in the history
  3. chore: cargo fmt

    TomAFrench committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    4300ce2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9995d2b View commit details
    Browse the repository at this point in the history
  5. chore: sync from noir repo (#4047)

    subrepo:
      subdir:   "noir"
      merged:   "9995d2ba2"
    upstream:
      origin:   "https://github.com/noir-lang/noir"
      branch:   "aztec-packages"
      commit:   "9995d2ba2"
    git-subrepo:
      version:  "0.4.6"
      origin:   "https://github.com/ingydotnet/git-subrepo"
      commit:   "110b9eb"
    TomAFrench authored and AztecBot committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a4b6635 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Configuration menu
    Copy the full SHA
    0c185c2 View commit details
    Browse the repository at this point in the history
  2. chore: bump version

    TomAFrench committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    e6d3e73 View commit details
    Browse the repository at this point in the history
  3. chore: bump bb.js

    TomAFrench committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3541dd0 View commit details
    Browse the repository at this point in the history
  4. feat!: Unify ABIs between nargo and yarn-project (#3989)

    Changes the output of `nargo` and `noir-wasm` to generate a single
    artifact that includes debug information. Compiled contracts now have a
    `file_map` at the root of the artifact, and a `debug_symbols` within
    each function. For consistency, compiled programs also have `file_map`
    and `debug_symbols`. Debug symbols are compressed and base64-encoded, as
    they were by the former `noir-compiler` postprocessing. The `debug` json
    artifact is no longer emitted.
    
    Removes all code related to generating `yarn-project`-specific ABIs from
    noir compiler. Instead, `types` now exposes a `loadContractArtifact`
    that renames fields as needed (and use camel instead of snake case), and
    is required when loading a noir contract artifact. Autogenerated types
    run this automatically.
    
    Since we are no longer post-processing artifacts, the `noir-contracts`
    project shape is changed. JSON files live in the `target` folder where
    nargo outputs them (this is not configurable), and are loaded by the
    autogenerated typescript interfaces from there.
    
    As part of the refactor, moves functions for getting functions debug
    info out of `acir-simulator` and into `types`.
    
    **Breaking change**: This removes the need to run `codegen` for using a
    compiled contract. However, when creating a new contract object from
    aztec.js, a dev needs to call `loadContractArtifact`.
    
    **Future changes**: Type information for a compilation artifact is now
    spread all over the place, and duplicated in more than one place. There
    are types defined within rust code in Noir as
    `[wasm_bindgen(typescript_custom_section)]`, others defined within
    typescript code in the `noir_wasm` package, others in `foundation`, and
    others in `types`. We should unify it in a single place.
    
    Fixes AztecProtocol/aztec-packages#3812
    
    Supersedes #3906
    
    Noir subrepo has been pushed to
    #4035 to run the Noir CI
    spalladino authored and AztecBot committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    0858aa4 View commit details
    Browse the repository at this point in the history
  5. git subrepo pull (merge) noir

    subrepo:
      subdir:   "noir"
      merged:   "b70f643949"
    upstream:
      origin:   "https://github.com/noir-lang/noir"
      branch:   "aztec-packages"
      commit:   "3541dd02ca"
    git-subrepo:
      version:  "0.4.6"
      origin:   "https://github.com/ingydotnet/git-subrepo"
      commit:   "110b9eb"
    spalladino authored and AztecBot committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8ac47e5 View commit details
    Browse the repository at this point in the history
  6. fix: Nargo destination path in bootstrap cache (#4103)

    The destination path when copying nargo from the CI cache in
    bootstrap_cache was wrong, it was getting copied to
    `~/monorepo/noir/noir/target/release` (note the double `noir`).
    spalladino authored and AztecBot committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    5a1b2bb View commit details
    Browse the repository at this point in the history
  7. chore: Fixes many broken urls (#4109)

    jzaki authored and AztecBot committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    13f93d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Configuration menu
    Copy the full SHA
    88ecd78 View commit details
    Browse the repository at this point in the history
  2. chore: formatting fix

    TomAFrench committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    40c2dc3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3558c72 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b26dba8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    727473c View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    602f23f View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. feat!: Add big int opcodes (without implementation) (#4050)

    Adds the biginteger opcode skeleton
    #4040
    
    The PR adds ACIR opcodes for bigint operations. It does not provide any
    implantation of the opcodes, neither in BB, in the solver or in Brillig.
    
    ---------
    
    Co-authored-by: kevaundray <[email protected]>
    2 people authored and AztecBot committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    7dba0a1 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. feat: implement bigint in Noir, using bigint opcodes (#4198)

    This PR enables big integers in Noir using the bigint opcodes.
    It does not implement bigints in ACVM which is required to solve the
    opcodes.
    It also does not implement bigints opcodes in Barretenberg, which is
    required to generate the constraints.
    
    However it provides a BigInt structure in the stdlib so you can write
    code like this in Noir, which will be compiled into ACIR using the
    bigint opcodes.
    
    ```
        let a = bigint::BigInt::from_le_bytes([3], [23]);
        let b = bigint::BigInt::from_le_bytes([5], [23]);
        let c = a+b;
        let bytes = c.to_le_bytes();
        std::println(bytes[0]);
    
    ```
    
    I did not add a test yet because ACMV solver is not yet implemented.
    
    ---------
    
    Co-authored-by: kevaundray <[email protected]>
    2 people authored and AztecBot committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    914403d View commit details
    Browse the repository at this point in the history
  2. feat: Implement Embedded EC add and double opcodes (#3982)

    This PR resolves the following points from the issue
    #3983:
    
    - Add ACVM solvers for ECADD and ECDOUBLE
    - Generate circuits for ECADD and ECDOUBLE in BB/dsl
    - Add unit test in BB/DSL for these new opcodes
    - Add integration test in Noir demonstrating the use of the opcodes
    guipublic authored and AztecBot committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    9debf5c View commit details
    Browse the repository at this point in the history
  3. feat!: remove ec_double opcode (#4210)

    Remove the ec_double ACIR opcode since we can use EC addition with
    itself to double a point.
    guipublic authored and AztecBot committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    af203d6 View commit details
    Browse the repository at this point in the history
  4. feat!: add opcode for poseidon2 permutation (#4214)

    Related to issue: #4037
    
    The PR adds the opcode to ACIR and updates BB and Noir accordingly.
    Furthermore you can use it via a foreign function in the stdlib. This
    will generate the proper ACIR opcode but the solver will not be able to
    solve it and BB will skip it.
    guipublic authored and AztecBot committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    435d041 View commit details
    Browse the repository at this point in the history
  5. refactor: delete C++ PK circuits (#4219)

    This is no longer used. We still hold value in referencing the code, BUT
    this is best done in historical commits. As it no longer builds, and we
    don't intend to maintain it, it is best to not mislead people by
    including it now.
    
    ---------
    
    Co-authored-by: ludamad <[email protected]>
    2 people authored and AztecBot committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    e470b94 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. feat!: add opcode for sha256 compression function (#4229)

    The opcode will allow SHA256 implementation in Noir with support to
    variable length input, while keeping BB native performance.
    
    The PR includes usage of the function in stdlib, but does not include
    implementation of the function. It should be added in a future PR for
    ACVM, BB, Brillig and Noir (for constant folding).
    guipublic authored and AztecBot committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2c463bc View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Configuration menu
    Copy the full SHA
    52fc077 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    031c534 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ea6aebc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    14d491b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7b50fd9 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Configuration menu
    Copy the full SHA
    1f246fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    68c05f6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6bc7107 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1e43b32 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aa163e0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5503531 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2badd02 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. chore: git subrepo commit (merge) noir (#4321)

    subrepo:
      subdir:   "noir"
      merged:   "ab74cff2b"
    upstream:
      origin:   "https://github.com/noir-lang/noir"
      branch:   "aztec-packages"
      commit:   "2badd023e"
    git-subrepo:
      version:  "0.4.6"
      origin:   "https://github.com/ingydotnet/git-subrepo"
      commit:   "110b9eb"
    
    Please read [contributing guidelines](CONTRIBUTING.md) and remove this
    line.
    sirasistant authored and AztecBot committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ddd94a2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    caf0b25 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into aztec-packages

    * master:
      fix(lsp): replace panics with errors (#4209)
      feat: Improve Error Handling for Cargo in Bootstrap Script (#4211)
      fix: prevent declarations of blackbox functions outside of the stdlib (#4177)
      feat: disable unused variable checks on low-level and oracle functions (#4179)
      chore: Rename acir_docs.md to README.md (#4208)
      feat: remove replacement of boolean range opcodes with `AssertZero` opcodes (#4107)
      chore(docs): updating docs to match new recursion interfacee (#4187)
      feat!: Sync commits from `aztec-packages` (#4144)
    TomAFrench committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b38ffdd View commit details
    Browse the repository at this point in the history
  4. Merge branch 'master' into aztec-packages

    * master:
      fix: apply range constraints to return values from unconstrained functions (#4217)
    TomAFrench committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    9944bb1 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. chore(acir)!: Move is_recursive flag to be part of the circuit defi…

    …nition (#4221)
    
    Resolves #4222
    
    Currently in order to specify whether we want to use a prover that
    produces SNARK recursion friendly proofs, we must pass a flag from the
    tooling infrastructure. This PR moves it be part of the circuit
    definition itself.
    
    The flag now lives on the Builder and is set when we call
    `create_circuit` in the acir format. The proof produced when this flag
    is true should be friendly for recursive verification inside of another
    SNARK. For example, a recursive friendly proof may use Blake3Pedersen
    for hashing in its transcript, while we still want a prove that uses
    Keccak for its transcript in order to be able to verify SNARKs on
    Ethereum.
    
    However, a verifier does not need a full circuit description and should
    be able to verify a proof with just the verification key and the proof.
    An `is_recursive_circuit` field was thus added to the verification key
    as well so that we can specify the accurate verifier to use for a given
    proof without the full circuit description.
    
    ---------
    
    Signed-off-by: kevaundray <[email protected]>
    Co-authored-by: ledwards2225 <[email protected]>
    Co-authored-by: kevaundray <[email protected]>
    3 people authored and AztecBot committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9a70040 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. chore: Sync to noir-lang/noir

    feat: Allow nested arrays and vectors in Brillig foreign calls (AztecProtocol/aztec-packages#4478)
    feat: allow brillig to read arrays directly from memory (AztecProtocol/aztec-packages#4460)
    feat(avm): back in avm context with macro - refactor context (AztecProtocol/aztec-packages#4438)
    chore!: rename bigint_neg into bigint_sub (AztecProtocol/aztec-packages#4420)
    chore: add bigint solver in ACVM and add a unit test for bigints in Noir (AztecProtocol/aztec-packages#4415)
    feat!: Add expression width into acir (AztecProtocol/aztec-packages#4014)
    feat: Add bit size to const opcode (AztecProtocol/aztec-packages#4385)
    feat(aztec-nr): initial work for aztec public vm macro (AztecProtocol/aztec-packages#4400)
    chore: surpress chained macro warning (AztecProtocol/aztec-packages#4396)
    feat!: init storage macro (AztecProtocol/aztec-packages#4200)
    chore(acir)!: Move `is_recursive` flag to be part of the circuit definition (AztecProtocol/aztec-packages#4221)
    AztecBot committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f1b9151 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Configuration menu
    Copy the full SHA
    99bb998 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    658cbb7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a26142 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    15a507b View commit details
    Browse the repository at this point in the history
  5. chore: formatting fix

    TomAFrench committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    2a66948 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8440567 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f9493e7 View commit details
    Browse the repository at this point in the history