chore(docs): updating docs to match new recursion interfacee #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
signorecello
requested review from
critesjosh,
vezenovm,
Savio-Sou and
a team
|
🚀 Deployed on https://65b8c30f45a76bc15111d139--noir-docs.netlify.app |
critesjosh
approved these changes
Jan 27, 2024
|
Can you update the PR title to represent what this PR is doing in the docs? |
signorecello
changed the title
|
Sure, sorry took it from the commit message (which wasn't descriptive either I reckon) |
|
Thank you for drafting the PR! Can we also add the changes into |
vezenovm
approved these changes
Jan 29, 2024
5 tasks
catmcgee
approved these changes
Jan 30, 2024
|
Gonna YOLO this without re-review for |
TomAFrench
added a commit
that referenced
this pull request
Jan 31, 2024
* master: fix(lsp): replace panics with errors (#4209) feat: Improve Error Handling for Cargo in Bootstrap Script (#4211) fix: prevent declarations of blackbox functions outside of the stdlib (#4177) feat: disable unused variable checks on low-level and oracle functions (#4179) chore: Rename acir_docs.md to README.md (#4208) feat: remove replacement of boolean range opcodes with `AssertZero` opcodes (#4107) chore(docs): updating docs to match new recursion interfacee (#4187) feat!: Sync commits from `aztec-packages` (#4144)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
# Description ## Problem\* Followup to #4187 for resolving #4139 ## Summary\* We no longer need to distinguish between `generateIntermediateProof` and `generateFinalProof`. This will go into effect once AztecProtocol/aztec-packages#4221 is merged and released. ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR. # PR Checklist\* - [ ] I have tested the changes locally. - [ ] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings. --------- Co-authored-by: José Pedro Sousa <[email protected]> Co-authored-by: Cat McGee <[email protected]>
TomAFrench
added a commit
that referenced
this pull request
Feb 2, 2024
* master: (22 commits) feat: remove predicate from `sort` intrinsic function (#4228) chore: add test for missing lambda closure environment (#2120) (#4212) chore(docs): Updates following `is_recursive` flag removal (#4199) fix: from field with constant values (#4226) feat: Option expect method (#4219) feat: Evaluation of dynamic assert messages (#4101) chore(docs): XOR typo in docs (#4223) fix: apply range constraints to return values from unconstrained functions (#4217) fix(lsp): replace panics with errors (#4209) feat: Improve Error Handling for Cargo in Bootstrap Script (#4211) fix: prevent declarations of blackbox functions outside of the stdlib (#4177) feat: disable unused variable checks on low-level and oracle functions (#4179) chore: Rename acir_docs.md to README.md (#4208) feat: remove replacement of boolean range opcodes with `AssertZero` opcodes (#4107) chore(docs): updating docs to match new recursion interfacee (#4187) feat!: Sync commits from `aztec-packages` (#4144) feat: multiply first to allow more ACIR gen optimizations (#4201) feat: Move bounded_vec into the noir stdlib (#4197) chore: simplify marking black box function outputs as solvable (#4194) chore(doc): Add docs for `assert_max_bit_size` (#4196) ...
|
There @signorecello @vezenovm was that intentional? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR documents the new recursion interface.
Problem*
Resolves #4139
Resolves AztecProtocol/dev-rel#148
Summary*
aggregation objectwhile retaining the mention that recursive proofs are actually aggregation of proofsverify_proofreferenceAdditional Context
noir-examplesis actually not working with this new interface, as I'm blocked by a weird issue where proofs give me my dear friendunreachableWill debug that next week with @TomAFrench but I think we're good to push the docs for now.