Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the #[recursive] attribute on the Recursive Proofs doc page #4392

Closed
Savio-Sou opened this issue Feb 16, 2024 · 0 comments · Fixed by #4399
Closed

Document the #[recursive] attribute on the Recursive Proofs doc page #4392

Savio-Sou opened this issue Feb 16, 2024 · 0 comments · Fixed by #4399
Assignees
Labels
documentation Improvements or additions to documentation recursion Recursive proving / proof aggregation
Milestone

Comments

@Savio-Sou
Copy link
Collaborator

Savio-Sou commented Feb 16, 2024

Problem

The Recursive Proofs doc page was updated, but without mentioning of the new #[recursive] attribute: #4187 (comment)

Happy Case

Supplement how is the attribute used in the "Example usage" section.

As v0.24.0 is pre-released, reminder to copy doc changes into version-v0.24.0 when making them.

Project Impact

Blocker

Impact Context

Prerequisite to v0.24.0's public release aimed in the week of 26 Feb.

Workaround

None

Workaround Description

No response

Additional Context

Not a must but I would personally recommend tackling noir-lang/noir-examples#16 first to ensure we have a working example before documenting it.

Would you like to submit a PR for this Issue?

None

Support Needs

No response

@Savio-Sou Savio-Sou added enhancement New feature or request documentation Improvements or additions to documentation labels Feb 16, 2024
@Savio-Sou Savio-Sou added this to Noir Feb 16, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Feb 16, 2024
@Savio-Sou Savio-Sou added this to the 0.24 milestone Feb 16, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 22, 2024
# Description

## Problem

Step towards [#4392](#4392)

The documentation for Recursive Proofs was lacking information on the
newly introduced `#[recursive]` attribute, which is crucial for
understanding how to mark circuits for recursive proof generation.

## Summary

This pull request updates the Recursive Proofs documentation page to
include a comprehensive section on the `#[recursive]` attribute. It
explains the attribute's purpose, how it should be used, and provides an
example demonstrating its application within a circuit definition.

## Additional Context

The introduction of the `#[recursive]` attribute simplifies the process
of designating circuits for recursive proofs, eliminating the need for
manual flagging in the tooling infrastructure.

## Documentation

- [ ] No documentation needed.
- [x] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist

- [x] I have tested the changes locally.
- [x] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.

---------

Co-authored-by: Savio <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Feb 22, 2024
@Savio-Sou Savio-Sou added recursion Recursive proving / proof aggregation and removed enhancement New feature or request labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation recursion Recursive proving / proof aggregation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants