Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fmt): don't lose line breaks between comments #3505

Merged
merged 3 commits into from Nov 17, 2023
Merged

chore(fmt): don't lose line breaks between comments #3505

merged 3 commits into from Nov 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2023

Description

Problem

Resolves #3399 (comment)

cc @TomAFrench

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@ghost ghost changed the title chore: don't lose line breaks between comments chore(fmt): don't lose line breaks between comments Nov 17, 2023
@jfecher jfecher added this pull request to the merge queue Nov 17, 2023
Merged via the queue into noir-lang:master with commit 73c2077 Nov 17, 2023
33 checks passed
@TomAFrench
Copy link
Member

Looks good, thanks @f01dab1e!

TomAFrench added a commit that referenced this pull request Nov 17, 2023
* master:
  fix: adding proving key initialization (#3322)
  chore(fmt): don't lose line breaks between comments (#3505)
  feat: Add LSP command to profile opcodes in vscode (#3496)
TomAFrench added a commit that referenced this pull request Nov 17, 2023
* master:
  chore: update `async-lsp` to v0.1.0 (#3489)
  fix: adding proving key initialization (#3322)
  chore(fmt): don't lose line breaks between comments (#3505)
  feat: Add LSP command to profile opcodes in vscode (#3496)
  chore: format integration tests (#3399)
  chore: Refactor parser tests (with concat!()) (#3500)
  chore: format function signature (#3495)
  chore: update `self_cell` to v1.0.2 (#3487)
  chore: Fix broken link (#3497)
  chore: update array formatting style (#3486)
  chore(fmt): add fn_call_width (#3480)
  chore: Fix undesirable line break before '{' in function signature with comments (#3473)
  fix: apply predicate to over/underflow checks (#3494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants