chore: Refactor parser tests (with concat!()) #3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pczarn
changed the title
pczarn
force-pushed
the
refactor-parser-tests
branch
from
b5f0d9b
to
0cc6c00
Compare
|
@jfecher will you review? |
|
What is gates diff, and why is it failing here? |
|
@pczarn looks like it was just a network issue failing the test. |
jfecher
approved these changes
Nov 16, 2023
TomAFrench
added a commit
that referenced
this pull request
Nov 17, 2023
* master: chore: update `async-lsp` to v0.1.0 (#3489) fix: adding proving key initialization (#3322) chore(fmt): don't lose line breaks between comments (#3505) feat: Add LSP command to profile opcodes in vscode (#3496) chore: format integration tests (#3399) chore: Refactor parser tests (with concat!()) (#3500) chore: format function signature (#3495) chore: update `self_cell` to v1.0.2 (#3487) chore: Fix broken link (#3497) chore: update array formatting style (#3486) chore(fmt): add fn_call_width (#3480) chore: Fix undesirable line break before '{' in function signature with comments (#3473) fix: apply predicate to over/underflow checks (#3494)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
The tests that I added to
parserare quite unreadable.Summary*
Uses
concat!macro to make multiline pieces of code. Adds a helper function to test mutiple cases and check their errors given a parser function.Documentation*
Check one:
PR Checklist*
cargo fmton default settings.