chore(ssa refactor): Add code to handle less than comparison #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This method needs to know the bit size, so we cache this information whenever we do a range constraint. We should ideally also cache it for constants too since we can figure out their bit-sizes easily
|
This was failing before because the result was not being cached when we did a cast operation. I incorrectly assumed that the value_id of the input to cast will equal the value_id of the output to cast |
kevaundray
commented
May 28, 2023
crates/nargo_cli/tests/test_data_ssa_refactor/simple_comparison/src/main.nr
Show resolved
Hide resolved
kevaundray
commented
May 28, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Show resolved
Hide resolved
kevaundray
commented
May 28, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Show resolved
Hide resolved
kevaundray
commented
May 28, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Show resolved
Hide resolved
kevaundray
commented
May 28, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/generated_acir.rs
Show resolved
Hide resolved
kevaundray
commented
May 28, 2023
|
This is now blocked by #1435 since we are now producing circuits which have a width greater than three |
joss-aztec
reviewed
May 30, 2023
jfecher
reviewed
May 30, 2023
crates/noirc_evaluator/src/ssa_refactor/acir_gen/acir_ir/acir_variable.rs
Show resolved
Hide resolved
I think this might be because of a rebase, we just merged merkle changes into master |
kevaundray
force-pushed
the
kw/add-comparison
branch
from
346a216
to
7d8753b
Compare
|
Can we merge master with this PR so the extraneous diffs get removed? |
We are merging into the range-constraints PR so I think we need to update it there |
jfecher
previously approved these changes
May 30, 2023
|
Diff should be clean now! |
joss-aztec
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds code to handle the less than operation, to handle more than, we just need to handle the NOT operation which we can put in another PR.
Problem*
Resolves
Summary*
This PR sets out to
Example
Before:
After:
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.