Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track more information about the bit size of Variables during Acir Gen #1439

Closed
Tracked by #1376
joss-aztec opened this issue May 30, 2023 · 3 comments
Closed
Tracked by #1376
Labels
enhancement New feature or request refactor ssa

Comments

@joss-aztec
Copy link
Contributor

Problem

Following #1433, AcirContext's variables_to_bit_sizes will track bit sizes when casting. This doesn't capture all known bit sizes.

Happy Case

This tracking should be extended to cover all other cases where such information can be inferred - e.g. that comparison operators produce booleans.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response

@joss-aztec
Copy link
Contributor Author

@kevaundray kevaundray changed the title Acir gen: more thorough tracking of bit size Track more information about the bit size of Variables during Acir Gen May 30, 2023
@kevaundray
Copy link
Contributor

Also see this comment: #1433 (comment)

It dives a bit into range constraint handling too, which we could branch off as a separate issue

@joss-aztec
Copy link
Contributor Author

Closing, as bit size tracking has since been removed in favour of acir_gen/mod passing in such information at the point of use.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor ssa
Projects
Archived in project
Development

No branches or pull requests

2 participants