feat(nargo): split nargo into core and cli packages
#1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
nargo into core and cli packagesnargo into core and cli packages
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This was referenced Mar 31, 2023
TomAFrench
added a commit
that referenced
this pull request
Apr 3, 2023
* master: chore: handle public parameters and return values separately in evaluator (#1062) chore(ssa): Rename ObjectType::Pointer to ObjectType::ArrayPointer (#1077) chore(ssa): indent NumericType into ObjectType (#810) chore: apply spelling fixes (#1073) feat: Implement `std::unsafe::zeroed` (#1048) fix: crash when typechecking fields that don't exist (#1070) feat: Implement arrays of structs (#1068) feat(nargo): split `nargo` into core and cli packages (#1065) chore: split wasm crate into submodules (#1066)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Related to #1063
Description
Summary of changes
This PR splits the
nargopackage intonargoandnargo_cli.nargo_clibuilds the currentnargobinary.nargois a core library which will be the interface for other programs to interact with. Any logic which isn't specific to the command line should exist here.Note this doesn't close #1063 as it's just the very first step of splitting these crates, we can migrate more functionality in future. This PR however performs the initial diff-heavy changes for just rearranging files.
Dependency additions / changes
Test additions / changes
Checklist
cargo fmtwith default settings.Documentation needs
Additional context