-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ssa): indent NumericType into ObjectType #810
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create helper methods for common operations involving NumericType
kevaundray
commented
Feb 11, 2023
jfecher
reviewed
Feb 13, 2023
jfecher
reviewed
Feb 13, 2023
This PR looks good but needs merge conflict resolution |
jfecher
previously approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
auto-merge was automatically disabled
February 28, 2023 17:40
Merge queue setting changed
joss-aztec
approved these changes
Mar 31, 2023
TomAFrench
added a commit
that referenced
this pull request
Apr 3, 2023
* master: chore: handle public parameters and return values separately in evaluator (#1062) chore(ssa): Rename ObjectType::Pointer to ObjectType::ArrayPointer (#1077) chore(ssa): indent NumericType into ObjectType (#810) chore: apply spelling fixes (#1073) feat: Implement `std::unsafe::zeroed` (#1048) fix: crash when typechecking fields that don't exist (#1070) feat: Implement arrays of structs (#1068) feat(nargo): split `nargo` into core and cli packages (#1065) chore: split wasm crate into submodules (#1066)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Description
Before this PR, the NumericType and ObjectType looked like:
Noting that Signed, Unsigned and NativeField were duplicated. This PR deduplicates the structure by doing:
Summary of changes
Dependency additions / changes
Test additions / changes
Checklist
cargo fmt
with default settings.Additional context