-
Notifications
You must be signed in to change notification settings - Fork 16
feat(acir)!: Add a public outputs field #56
Conversation
Now we have an explicit return type on the ABI this should be able to be handled seamlessly by the evaluator. Would you like me to fix up any conflicts so we can get this merged? |
Just merged the conflicts -- One thing to double check is that the definition of public outputs here also matches the definition being used in Noir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on https://aztecprotocol.slack.com/archives/C0183F0V42V/p1676636370362909?thread_ts=1676636143.866669&cid=C0183F0V42V, we may want to take the opportunity to rename these fields for more clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one small comment re docs
Co-authored-by: kevaundray <[email protected]>
This LGTM -- @TomAFrench you'll need to approve since the PR was originally made by me |
Ah, that's true. Thanks. Approving now. |
Related issue(s)
(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)
Resolves (link to issue)
Description
Summary of changes
(Describe the changes in this PR. Point out breaking changes if any.)
Dependency additions / changes
(If applicable.)
Test additions / changes
(If applicable.)
Checklist
cargo fmt
with default settings.Additional context
(If applicable.)