You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Currently we have the concept of a public input, and we have the concept of a "return" field in the public inputs which functionally serves as public output.
Solution
We can:
Add an optional return field in the Abi which signifies the output
Add a public outputs vector in ACIR to signify public witness values which are semantically output
The second point is blocked until we complete the ACIR migration
Alternatives considered
Additional context
This cleans up some of the code in the package manager as a side effect; because ACIR does not have the concept of a public output, nargo needs to ensure that when we pass public input values, we do not have any duplicates. This duplication can happen when a public input is set as a public output.
If we add public outputs to ACIR, we can by proxy add logic to deduplicate public input/output indices
SSA setpub instruction will then add to the public_outputs field in ACIR instead of the public inputs field
The text was updated successfully, but these errors were encountered:
Problem
Currently we have the concept of a public input, and we have the concept of a "return" field in the public inputs which functionally serves as public output.
Solution
We can:
return
field in the Abi which signifies the outputThe second point is blocked until we complete the ACIR migration
Alternatives considered
Additional context
If we add public outputs to ACIR, we can by proxy add logic to deduplicate public input/output indices
public_outputs
field in ACIR instead of the public inputs fieldThe text was updated successfully, but these errors were encountered: