This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
chore(acvm)!: Make internals of ACVM private #353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #354
Summary*
This PR restricts the public interface of the ACVM so that we can make changes to the internal solvers without it being a breaking change.
Motivation for this PR being that we've removed the need for backends to implement 80% of the black box solvers so we don't need to expose them (at which point we might as well handle the rest of the interface). Once this is done then I can refactor these to expose the underlying hash function implementations out to ACVM simulator (#300) without having to worry about further breaking changes.
Filtering this change through to noir atm to test.DoneAdditional Context
PR Checklist*
cargo fmt
on default settings.