Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

chore(acvm)!: Make internals of ACVM private #353

Merged
merged 5 commits into from
Jun 9, 2023
Merged

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Jun 9, 2023

Description

Problem*

Resolves #354

Summary*

This PR restricts the public interface of the ACVM so that we can make changes to the internal solvers without it being a breaking change.

Motivation for this PR being that we've removed the need for backends to implement 80% of the black box solvers so we don't need to expose them (at which point we might as well handle the rest of the interface). Once this is done then I can refactor these to expose the underlying hash function implementations out to ACVM simulator (#300) without having to worry about further breaking changes.

Filtering this change through to noir atm to test. Done

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench marked this pull request as ready for review June 9, 2023 08:00
@TomAFrench TomAFrench changed the title chore(acvm)!: make internals of PWG private chore(acvm)!: Make internals of ACVM private Jun 9, 2023
@kevaundray
Copy link
Contributor

Seems okay to flatten the signature structure and once we get more signatures we can add it back

@kevaundray kevaundray added this pull request to the merge queue Jun 9, 2023
Merged via the queue into master with commit c902a01 Jun 9, 2023
@kevaundray kevaundray mentioned this pull request Jun 9, 2023
@TomAFrench TomAFrench deleted the restructure-pwg branch June 10, 2023 06:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict the public interface of the ACVM
2 participants