Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Re-export black box functions for ACVM simulator to expose #300

Closed
1 task
TomAFrench opened this issue May 22, 2023 · 0 comments · Fixed by #431
Closed
1 task

Re-export black box functions for ACVM simulator to expose #300

TomAFrench opened this issue May 22, 2023 · 0 comments · Fixed by #431
Assignees
Labels
enhancement New feature or request

Comments

@TomAFrench
Copy link
Member

Problem

The ACVM simulator has an open issue to expose implementation of the black box function solvers: noir-lang/noir#2811.

We want to enforce consistency rather than having a separate implementation in the simulator so ideally we'd reuse the solvers which exist within ACVM however these have a pretty non-ideal interface, e.g.:

sha256(
    initial_witness: &mut WitnessMap,
    inputs: &[FunctionInput],
    outputs: &[Witness],
)

Proposed solution

To ensure consistency between ACVM and the simulator we should rework the underlying solvers within ACVM to be "pure" and then wrap these in a function which handles writing to the witness map.

Alternatives considered

No response

Additional context

No response

Submission Checklist

  • Once I hit submit, I will assign this issue to the Project Board with the appropriate tags.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Archived in project
1 participant