WIP: GitHub download by URL #680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnor
reviewed
Feb 23, 2017
graphs/Save.fbp
Outdated
| @@ -42,8 +42,9 @@ SplitSpec OUT -> IN EnsureId | |||
| StoreName OUT -> NAME Store(indexeddb/GetStore) | |||
| WriteTransaction TRANSACTION -> TRANSACTION Store STORE -> STORE Put(indexeddb/Put) | |||
| EnsureId OUT -> VALUE Put | |||
| 'state=ok' -> PROPERTY SetOk(objects/SetProperty) | |||
| Put KEY -> START CreateOk(objects/CreateObject) OUT -> IN SetOk OUT -> IN MergeContext | |||
| StoreName OUT -> TYPE CreateOk(ui/PersistedToContext) | |||
There was a problem hiding this comment.
"Persisted" is whatever we just saved ... graph, runtime, component, project, spec.
jonnor
reviewed
Feb 23, 2017
| async: true | ||
| , (data, groups, out, callback) -> | ||
| api = octo.api() | ||
| api.token data.state.user['github-token'] if data.state.user?['github-token'] |
There was a problem hiding this comment.
Don't like that a generic and should-have-small-scope component like this gets the entire state. It makes data dependencies invisible in the graph, and lets the component do whatever it wants.
There was a problem hiding this comment.
Fair point, we can plug a GetActionValues in front of this so we only pick the pieces we need.
jonnor
reviewed
Feb 23, 2017
components/CheckGistExists.coffee
Outdated
| out: ['existing', 'new'] | ||
| async: true | ||
| , (data, groups, out, callback) -> | ||
| unless data.state?.projects?.length |
There was a problem hiding this comment.
Same, I think this component should just get projects
|
Here is how the high-level architecture should look like. With a bit of subgraphing we can make
|
bergie
force-pushed
the
github_download_url
branch
from
2b929bd
to
aaaa238
Compare
This was referenced May 9, 2017
Merged
This was referenced Jun 15, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will example a "Open in Flowhub" mechanism where users can provide a URL to open a given GitHub repo directly in Flowhub with:
(these are essentially GitHub URLs with
https://github.com/replaced withhttps://app.flowhub.io/#github/)If user already has that repo downloaded, we redirect to normal project view. If not, we download and then redirect.
We will be able to use this mechanism also for the example projects, meaning that they'll get downloaded to user's IndexedDB and user can then edit them locally with persistence.
The same behavior is applied also to gist examples, which solves #229 and #475.
Fixes #638