Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when removing graph #329

Open
bergie opened this issue Feb 23, 2017 · 3 comments
Open

Error when removing graph #329

bergie opened this issue Feb 23, 2017 · 3 comments
Labels

Comments

@bergie
Copy link
Member

bergie commented Feb 23, 2017

When you set the graph of the-graph-editor to NULL (for example, when navigating away from a graph in noflo-ui), we get an error:

screenshot 2017-02-23 at 12 23 43

@jonnor
Copy link
Member

jonnor commented Feb 23, 2017

I suspect there are other things broken in this case also, like stale state in component library etc. As far as I know, noflo-ui used to just swap the entire widget, right?

@bergie
Copy link
Member Author

bergie commented Feb 23, 2017

@jonnor nope, we keep one widget and change graph. Current master of noflo-ui keeps the last-seen graph in state until a new one is provided, which causes occasional funkiness. This is fixed in noflo/noflo-ui#680, but that unfortunately causes this issue with the-graph-editor

@jonnor jonnor added the bug label Mar 23, 2017
@jonnor
Copy link
Member

jonnor commented Aug 17, 2017

I'm tempted to consider graph property mandatory, and close this as wont-fix - unless there is an important usecase for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants