Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent invalid related nodes from being passed to the Database #104

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

zprobst
Copy link
Contributor

@zprobst zprobst commented Oct 12, 2023

closes #103

@zprobst zprobst requested a review from ccloes as a code owner October 12, 2023 16:23
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef4a0ab) 94.47% compared to head (99b5604) 94.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   94.47%   94.65%   +0.17%     
==========================================
  Files         123      123              
  Lines        3187     3197      +10     
==========================================
+ Hits         3011     3026      +15     
+ Misses        176      171       -5     
Flag Coverage Δ
3.10 94.65% <100.00%> (+0.17%) ⬆️
3.11 94.65% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nodestream/cli/operations/initialize_logger.py 100.00% <100.00%> (+29.41%) ⬆️
nodestream/model/desired_ingestion.py 82.22% <100.00%> (+1.26%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zprobst zprobst merged commit acc9df6 into main Oct 20, 2023
4 checks passed
@zprobst zprobst deleted the fix/prevent-invalid-relationsip-creation branch October 24, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Null relationship nodes in writes
2 participants