Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Null relationship nodes in writes #103

Closed
ccloes opened this issue Oct 12, 2023 · 0 comments · Fixed by #104
Closed

[BUG] Null relationship nodes in writes #103

ccloes opened this issue Oct 12, 2023 · 0 comments · Fixed by #104
Assignees
Labels
bug Something isn't working

Comments

@ccloes
Copy link
Contributor

ccloes commented Oct 12, 2023

Describe the bug
When a relationship node is null there should be a check prior to trying to write to the database. It results in failed writes and DB log messages like the following:

2023-08-22 20:59:07.738+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'targetRevision': (:ArgoApp {targetRevision: null})
2023-08-22 21:12:26.632+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'targetRevision': (:ArgoApp {targetRevision: null})
2023-09-27 19:35:41.892+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'name': (:GitBranch {name: null})
2023-09-27 20:02:18.203+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'name': (:GitBranch {name: null})
2023-09-27 20:57:00.068+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'name': (:GitBranch {name: null})
2023-09-27 21:31:52.992+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'name': (:GitBranch {name: null})
2023-09-27 21:50:15.457+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'name': (:GitBranch {name: null})
2023-09-27 22:29:00.706+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'name': (:GitBranch {name: null})
2023-09-27 23:00:39.617+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'name': (:GitBranch {name: null})
2023-09-28 06:30:22.295+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'name': (:GitBranch {name: null})
2023-09-28 07:46:50.282+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'name': (:GitBranch {name: null})
2023-09-28 12:47:10.717+0000 WARN  1 times: org.neo4j.graphdb.QueryExecutionException: Cannot merge the following node because of null property value for 'name': (:GitBranch {name: null})

To Reproduce
Steps to reproduce the behavior:

  1. Create a relationship node of null property field
  2. Write it to the database, and the DB will log errors like above
  3. Cry

Expected behavior
Nodestream should check for this prior to sending it to the database to prevent wasted cycles and errors in the logs. Nodestream should also log warnings of null relationship nodes.

@ccloes ccloes added the bug Something isn't working label Oct 12, 2023
@ccloes ccloes changed the title [BUG] [BUG] Null relationship nodes in writes Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants