Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the main prop for the application entry point. #94

Conversation

lholmquist
Copy link
Contributor

npm start will now look at the main property for the entry point. Port 8080 is now set as the default port instead of 3000. This is a fix related to nodeshift-archived/centos7-s2i-nodejs#33#issuecomment-382587104.

fixes #93

@ghost ghost assigned lholmquist Apr 23, 2018
@coveralls
Copy link

coveralls commented Apr 23, 2018

Coverage Status

Coverage remained the same at 95.313% when pulling 853ef17 on lholmquist:93-change-start-script-and-port into 4dc0598 on bucharest-gold:master.

npm start will now look at the main property for the entry point.  Port 8080 is now set as the default port instead of 3000.   This is a fix related to nodeshift-archived/centos7-s2i-nodejs#33\#issuecomment-382587104.

fixes nodeshift-starters#93
@lholmquist lholmquist force-pushed the 93-change-start-script-and-port branch from 853ef17 to fe3380e Compare April 23, 2018 19:11
@ghost ghost added the in progress label Apr 23, 2018
@lholmquist lholmquist merged commit fe3380e into nodeshift-starters:master Apr 23, 2018
@ghost ghost removed the in progress label Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Start Script and default port
2 participants