Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Start Script and default port #93

Closed
lholmquist opened this issue Apr 23, 2018 · 0 comments · Fixed by #94
Closed

Change Start Script and default port #93

lholmquist opened this issue Apr 23, 2018 · 0 comments · Fixed by #94
Assignees
@lholmquist
Labels
review

Comments

@lholmquist
Copy link
Contributor

Change the start to script to just be node . and add the main property with ./bin/www

Also change the default port from 3000 to 8080. This is related to nodeshift-archived/centos7-s2i-nodejs#33 (comment)
@lholmquist lholmquist self-assigned this Apr 23, 2018
lholmquist added a commit to lholmquist/nodejs-rest-http-crud that referenced this issue Apr 23, 2018
@lholmquist
fix: use the main prop for the application entry point.
282413e 
npm start will now look at the main property for the entry point.  Port 8080 is now set as the default port instead of 3000.   This is a fix related to nodeshift-archived/centos7-s2i-nodejs#33\#issuecomment-382587104.

fixes nodeshift-starters#93
@lholmquist lholmquist mentioned this issue Apr 23, 2018
Merged
lholmquist added a commit to lholmquist/nodejs-rest-http-crud that referenced this issue Apr 23, 2018
@lholmquist
fix: use the main prop for the application entry point.
4768897 
npm start will now look at the main property for the entry point.  Port 8080 is now set as the default port instead of 3000.   This is a fix related to nodeshift-archived/centos7-s2i-nodejs#33\#issuecomment-382587104.

fixes nodeshift-starters#93
@ghost ghost removed the in progress label Apr 23, 2018
@snyk-bot snyk-bot mentioned this issue Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lholmquist lholmquist

Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use the main prop for the application entry point. lholmquist/nodejs-rest-http-crud
1 participant
@lholmquist