Fix: Update the img link of 'schedule.svg' #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
richardlau
approved these changes
Feb 9, 2019
ghost
changed the title
fhemberger
reviewed
Feb 9, 2019
ZYSzys
approved these changes
Feb 9, 2019
We cannot see the 'schedule.png', so according to this submit (nodejs/Release@2bf2ea3), it seems the img was removed and we've used 'schedule.svg' instead. The reason why I use the parameter `?sanitize=true` is that we MUST make sure that the response type should be of img (Content-Type should be `img/svg+xml` instead of `text/plain`). For more about svg rendering on GitHub's server, please see these related posts: 1. isaacs/github#316 (comment) 2. https://stackoverflow.com/questions/13808020/include-an-svg-hosted-on-github-in-markdown (See 'Linking to RAW files (Does not work)'). Fix for: #2055
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Feb 10, 2019
Since we've got an easy way to analyze the anchor link's name (See: #2056). We can write these titles in a union way. So remove pure HTML codes and write them together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot see the 'schedule.png', so according to this submit (nodejs/Release@2bf2ea3), it seems the img was removed and we've used 'schedule.svg' instead.
The reason why I use the parameter
?sanitize=trueis that we MUST make sure that the response type should be of img (Content-Type shouldbeimg/svg+xmlinstead oftext/plain).For more about svg rendering on GitHub's server, please see these related posts:
Fix for: #2055