-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release.png
's missing in the release
page
#2055
Comments
ghost
changed the title
'Release.png''s missing in the 'release' page
Feb 9, 2019
Release.png
's missing in the release
page
ghost
mentioned this issue
Feb 9, 2019
fhemberger
pushed a commit
that referenced
this issue
Feb 9, 2019
We cannot see the 'schedule.png', so according to this submit (nodejs/Release@2bf2ea3), it seems the img was removed and we've used 'schedule.svg' instead. The reason why I use the parameter `?sanitize=true` is that we MUST make sure that the response type should be of img (Content-Type should be `img/svg+xml` instead of `text/plain`). For more about svg rendering on GitHub's server, please see these related posts: 1. isaacs/github#316 (comment) 2. https://stackoverflow.com/questions/13808020/include-an-svg-hosted-on-github-in-markdown (See 'Linking to RAW files (Does not work)'). Fix for: #2055
ghost
closed this as completed
Feb 10, 2019
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
We cannot see the 'schedule.png', so according to this submit (nodejs/Release@2bf2ea3), it seems the img was removed and we've used 'schedule.svg' instead. So the img is missing:
So I tended to help to change the link in the
about-release-schedule.hbs
like this: https://raw.githubusercontent.com/nodejs/Release/master/schedule.svgBut I cannot see the img either, I'm not sure whether I should copy an img into the
static/images
and refer it? Or just remove this img link totally because there's already a table now?The text was updated successfully, but these errors were encountered: