build: make test-ci output TAP to stdout and log #938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
rvagg
added a commit
that referenced
this pull request
Feb 24, 2015
Closes: #810 PR-URL: #938 Reviewed-By: Ben Noordhuis <[email protected]>
|
FYI TAP output now in Jenkins: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/190/nodes=iojs-armv7-ubuntu1401/tapTestReport/ |
|
@bnoordhuis @indutny can you have a look at some of the runs after this merge, e.g. https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/193/ Is the |
petkaantonov
pushed a commit
to petkaantonov/io.js
that referenced
this pull request
Feb 25, 2015
Closes: nodejs#810 PR-URL: nodejs#938 Reviewed-By: Ben Noordhuis <[email protected]>
|
@rvagg could be related to a stray process that I see locally after |
|
@rvagg this is what I see after |
|
@bnoordhuis this seems to be your thing b5f25a9 |
|
@indutny It is and I'm seeing that too, FWIW. I'll take a look. |
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this pull request
Feb 25, 2015
Fix parallel/test-stdio-closed introduced in commit b5f25a9 ("src:
ensure that file descriptors 0-2 are valid") to not keep spawning
child processes ad infinitum.
The test spawns itself as a child process but a missing return statement
made the child process spawn itself again, and again, and again.
It went unnoticed for some time because the child process exits almost
immediately afterwards, i.e. it didn't fill up the process table. The
observable effect was an iojs process that was quietly consuming CPU
cyles in the background with a PID that was constantly changing.
Refs: nodejs#938
PR-URL: nodejs#948
Reviewed-By: Fedor Indutny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roughly the same as #810 but removes
messagefromtest-ciso we can actually use it. Produce TAP output and write a test.tap file so Jenkins can pick it up.R= @bnoordhuis
R= @jbergstroem