-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: make test-ci target produce tap output #810
Conversation
Make `make test-ci` print output in TAP format. The default output doesn't show up in the Jenkins web view until the test suite finishes. The web view is line buffered and the test runner doesn't emit newlines until it's done. A nice side effect is that the test runner now prints each test's running time.
Don't have the know how to sign off, but +1 from me. |
Yes! There's probably some plug to generate build artefacts so we can single out individual tests from jenkins reports. |
we haven't actually been using test-ci, I switched to test-simple + test-message because of the broken addon stuff. I'll give this a try now and see how it goes. |
https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/169/ with this branch using test-ci The TAP plugin for Jenkins requires a TAP file be written (as far as I can see). I could adjust the Jenkins invocation to write stdout to a file but that's not going to work for Windows. Should we add an option to tools/test.py to print the progress output to a file as well as the console? |
I don't think the problems with addons & test-ci have been resolved by the look of it, /cc @chrisdickinson |
@rvagg as for storing results to file, would you prefer just redirecting sys.stdout or should I do something fancier? |
@rvagg iirc, addons break (I think) because this expression is evaluated and expanded before any of the make targets run, so Now as for how to fix that, I'm unsure. @isaacs? |
@jbergstroem my Python fu is not strong enough, I started tinkering with this but probably shouldn't waste my time if someone else can do it! Here's my proposal: a If it's too hard, then just to a file will do, I can make Jenkins print out the full output after it's finished I think which is better than nothing. |
@rvagg I'm thinking using I'll see what patch I can whip together over the weekend. |
I was working on that in #335 but it stalled (I forgot about it.) I'll pick it up again. |
@bnoordhuis Ok. Lets get that in first then. |
Closes: #810 PR-URL: #938 Reviewed-By: Ben Noordhuis <[email protected]>
TODO: put closing because this was mostly done in #938 |
Closes: nodejs#810 PR-URL: nodejs#938 Reviewed-By: Ben Noordhuis <[email protected]>
Make
make test-ci
print output in TAP format. The default outputdoesn't show up in the Jenkins web view until the test suite finishes.
The web view is line buffered and the test runner doesn't emit newlines
until it's done.
A nice side effect is that the test runner now prints each test's
running time.
R=@rvagg? I assume the Jenkins TAP plugin must be activated first.