Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip cluster-disconnect-race on Windows #5621

Closed

Conversation

gibfahn
Copy link
Member

@gibfahn gibfahn commented Mar 9, 2016

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

test

Description of change

See issue #5603 .
Skips simple/cluster-disconnect-race on Windows. This was already done in #4457 for V4, but the fix is slightly different for v0.12.

@rvagg presumably process.platform === 'win32' covers 64bit as well as 32bit windows?

@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. windows Issues and PRs related to the Windows platform. test Issues and PRs related to the tests. labels Mar 9, 2016
@orangemocha
Copy link
Contributor

Yes, process.platfrom is 'win32' for all Windows version (see https://nodejs.org/api/process.html#process_process_platform).

Change LGTM.

CI run: https://ci.nodejs.org/job/node-test-pull-request/1895/

@jasnell
Copy link
Member

jasnell commented Mar 11, 2016

LGTM

@gibfahn
Copy link
Member Author

gibfahn commented Mar 16, 2016

Okay, so the CI run had two failures, the first one seems to be a git connection error, and the second one is two test failures on Windows, test-dgram-multicast-multi-process.js and test-dns.js, which are presumably unrelated to this test.

Assuming those failures can be ignored, it looks like this PR is good to go.

jasnell pushed a commit that referenced this pull request Mar 16, 2016
PR-URL: #5621
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 16, 2016

Landed in v0.12-staging in ab907eb

@jasnell jasnell closed this Mar 16, 2016
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
PR-URL: nodejs/node#5621
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Alexis Campailla <[email protected]>
@gibfahn gibfahn deleted the cluster-disconnect-race-v0.12 branch December 16, 2016 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants