Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.12.11 cluster-disconnect-race failure on Win7 #5603

Closed
gibfahn opened this issue Mar 8, 2016 · 2 comments
Closed

v0.12.11 cluster-disconnect-race failure on Win7 #5603

gibfahn opened this issue Mar 8, 2016 · 2 comments
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Comments

@gibfahn
Copy link
Member

gibfahn commented Mar 8, 2016

The test simple/test-cluster-disconnect-race fails consistently for me on Windows 7.

Test introduced: #5153
Test fixed for windows in V4: Issue = #4450, PR = #4457

Based on that discussion, it looks like the test should be changed to simply skip on Windows. However, copying that fix gives a syntax error

const common = require('../common');
^^^^^
SyntaxError: Use of const in strict mode.
  • Version: v0.12.11
  • Platform: Windows 7 32 and 64 bit
Test failure:
python tools/test.py --mode=release --progress=tap simple/test-cluster-disconnect-race
1..1
not ok 1 - test-cluster-disconnect-race.js
#events.js:85
#      throw er; // Unhandled 'error' event
#            ^
#Error: write EPIPE
#    at exports._errnoException (util.js:746:11)
#    at ChildProcess.target._send (child_process.js:487:28)
#    at ChildProcess.target.send (child_process.js:419:12)
#    at sendHelper (cluster.js:679:8)
#    at send (cluster.js:515:5)
#    at Worker.disconnect (cluster.js:422:5)
#    at Worker.<anonymous> (C:\gib\code\node_debugging\node\test\simple\test-cluster-disconnect-race.js:22:13)
#    at Worker.<anonymous> (C:\gib\code\node_debugging\node\test\common.js:245:15)
#    at Worker.emit (events.js:110:17)
#    at ChildProcess.emit (events.js:110:17)
  ---
  duration_ms: 0.732
  ...
@gibfahn
Copy link
Member Author

gibfahn commented Mar 8, 2016

I also tried adding these lines (from the V4 fix) to the test, but I'm still getting the EPIPE error.

if (common.isWindows) {
  console.log('1..0 # Skipped: This test does not apply to Windows.');
  return;
}

@ChALkeR ChALkeR added windows Issues and PRs related to the Windows platform. v0.12 test Issues and PRs related to the tests. labels Mar 8, 2016
@rvagg
Copy link
Member

rvagg commented Mar 8, 2016

/cc @nodejs/testing

@gibm on v0.12 we don't have a common.isWindows so you can simply replace that with process.platform === 'win32'. Would you mind submitting a pull request against v0.12-staging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

No branches or pull requests

3 participants