-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: include git node release --promote to steps #55835
Merged
nodejs-github-bot
merged 3 commits into
nodejs:main
from
RafaelGSS:add-git-node-promote
Nov 19, 2024
Merged
doc: include git node release --promote to steps #55835
nodejs-github-bot
merged 3 commits into
nodejs:main
from
RafaelGSS:add-git-node-promote
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
aduh95
reviewed
Nov 13, 2024
Co-authored-by: Antoine du Hamel <[email protected]>
RafaelGSS
added
the
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
label
Nov 13, 2024
aduh95
reviewed
Nov 13, 2024
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
approved these changes
Nov 13, 2024
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Nov 13, 2024
RafaelGSS
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 19, 2024
joyeecheung
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 19, 2024
Landed in 172841c |
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
Refs: nodejs/node-core-utils#835 PR-URL: nodejs#55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
Refs: nodejs/node-core-utils#835 PR-URL: nodejs#55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 10, 2024
Refs: nodejs/node-core-utils#835 PR-URL: #55835 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node-core-utils#835