Skip to content

Commit

Permalink
doc: include git node release --promote to steps
Browse files Browse the repository at this point in the history
Refs: nodejs/node-core-utils#835
PR-URL: #55835
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
  • Loading branch information
RafaelGSS authored and aduh95 committed Nov 26, 2024
1 parent 8197815 commit 219f5f2
Showing 1 changed file with 17 additions and 6 deletions.
23 changes: 17 additions & 6 deletions doc/contributing/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -707,12 +707,23 @@ the build before moving forward. Use the following list as a baseline:

### 11. Tag and sign the release commit

Once you have produced builds that you're happy with, create a new tag. By
waiting until this stage to create tags, you can discard a proposed release if
something goes wrong or additional commits are required. Once you have created a
tag and pushed it to GitHub, you _**must not**_ delete and re-tag. If you make
a mistake after tagging then you'll have to version-bump and start again and
count that tag/version as lost.
Once you have produced builds that you're happy with you can either run
`git node release --promote`

```bash
git node release -S --promote https://github.com/nodejs/node/pull/XXXX
```

to automate the remaining steps until step 16 or you can perform it manually
following the below steps.

***

Create a new tag: By waiting until this stage to create tags, you can discard
a proposed release if something goes wrong or additional commits are required.
Once you have created a tag and pushed it to GitHub, you _**must not**_ delete
and re-tag. If you make a mistake after tagging then you'll have to version-bump
and start again and count that tag/version as lost.

Tag summaries have a predictable format. Look at a recent tag to see:

Expand Down

0 comments on commit 219f5f2

Please sign in to comment.