src: do not run IsWindowsBatchFile on non-windows #55560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55560 +/- ##
=======================================
Coverage 88.42% 88.43%
=======================================
Files 654 654
Lines 187662 187656 -6
Branches 36121 36121
=======================================
+ Hits 165939 165949 +10
+ Misses 14962 14951 -11
+ Partials 6761 6756 -5
|
richardlau
approved these changes
Oct 27, 2024
github-actions
bot
removed
the
request-ci
|
I specifically wrote it that way so that IsWindowsBatchFile and its call sites get type-checked by the compiler always and everywhere. Of course the function was still small and nimble back then. |
anonrig
added
the
author ready
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e160e54 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Oct 30, 2024
PR-URL: nodejs#55560 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Nov 1, 2024
PR-URL: #55560 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55560 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55560 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55560 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55560 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's not run
IsWindowsBatchFileon non-windows environments.